Re: [PATCH 4/4] gnu: matplotlib: Add gtk3 backends.

[ludo@gnu.org (Ludovic Courtès)]

Federico Beffa <beffa@ieee.org> skribis:

> This one is problematic: for the package to work the user has to define
>
> export GI_TYPELIB_PATH=~/.guix-profile/lib/girepository-1.0
>
> and
>
> export LD_LIBRARY_PATH=~/.guix-profile/lib
>
> The former is required to instruct 'gobject-introspection' where to
> find typelib files and should be fine, but I'm not sure how to display
> a message telling this at the end of the installation.

One should get a message about GI_TYPELIB_PATH, but only if
gobject-introspection is also installed.  Not sure if that helps.

> The latter is a hack. As discussed on another thread, the typelib
> files have references to dynamic libraries and they do not include the
> full path.  We are looking into a patch to add the full path into the
> typelib files, however, the patch only works on newer versions of
> 'gobject-introspection' which breaks several other packages.

Yes, right.

Speaking of which, could you (or Mark?) create a branch with all the
updates that you did, so we keep track of it?

> From e1e3df22ea06bd7325bc2a1fd389c89f13ccf752 Mon Sep 17 00:00:00 2001
> From: Federico Beffa <beffa@fbengineering.ch>
> Date: Thu, 11 Dec 2014 14:26:13 +0100
> Subject: [PATCH 4/4] gnu: matplotlib: Add gtk3 backends.
>
> * gnu/packages/python.scm (python-matplotlib, python2-matplotlib): Add
>   necessary inputs and 'configure-environment' phase.

The patch also move python-pyparsing from ‘inputs’ to
‘propagated-inputs’, so it would be good to mention it.

> +    (propagated-inputs
> +     `(("python-pyparsing" ,python-pyparsing)
> +       ("python-pygobject" ,python-pygobject)

Could you add a comment saying why they’re here?

>      (native-inputs
>       `(("pkg-config" ,pkg-config)
>         ("texlive" ,texlive)
> +       ("ghostscript" ,ghostscript)

This doesn’t sound GTK-related, no?

Thanks,
Ludo’.