From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCH] gnu: Add polipo. Date: Sun, 01 Feb 2015 01:40:28 -0500 Message-ID: <878ugif82r.fsf@netris.org> References: <87oaper041.fsf@taylan.uni.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHoCy-0002Hx-D7 for guix-devel@gnu.org; Sun, 01 Feb 2015 01:40:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YHoCt-0004Kn-P1 for guix-devel@gnu.org; Sun, 01 Feb 2015 01:40:36 -0500 Received: from world.peace.net ([50.252.239.5]:57713) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHoCt-0004Kg-EP for guix-devel@gnu.org; Sun, 01 Feb 2015 01:40:31 -0500 In-Reply-To: <87oaper041.fsf@taylan.uni.cx> ("\"Taylan Ulrich \=\?utf-8\?Q\?\=5C\=22Bay\=C4\=B1rl\=C4\=B1\=2FKammer\=5C\=22\=5C\=22\=22's\?\= message of "Sun, 01 Feb 2015 00:39:26 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Taylan Ulrich =?utf-8?Q?Bay=C4=B1rl=C4=B1=2FK?= =?utf-8?Q?ammer?= Cc: guix-devel@gnu.org taylanbayirli@gmail.com ("Taylan Ulrich "Bay=C4=B1rl=C4=B1/Kammer\"") write= s: > From 5178c21a46062b328677cfa2015419c270c6536b Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Taylan=3D20Ulrich=3D20Bay=3DC4=3DB1rl=3DC4=3DB1/Kammer?= =3D > > Date: Sun, 1 Feb 2015 00:03:19 +0100 > Subject: [PATCH] gnu: Add polipo. > > * gnu-system.am (GNU_SYSTEM_MODULES): Add polipo.scm. > * gnu/packages/polipo.scm: New file. > --- > gnu-system.am | 1 + > gnu/packages/polipo.scm | 60 +++++++++++++++++++++++++++++++++++++++++++= ++++++ > 2 files changed, 61 insertions(+) > create mode 100644 gnu/packages/polipo.scm > > diff --git a/gnu-system.am b/gnu-system.am > index 706ad57..03f148d 100644 > --- a/gnu-system.am > +++ b/gnu-system.am > @@ -222,6 +222,7 @@ GNU_SYSTEM_MODULES =3D \ > gnu/packages/photo.scm \ > gnu/packages/pkg-config.scm \ > gnu/packages/plotutils.scm \ > + gnu/packages/polipo.scm \ > gnu/packages/polkit.scm \ > gnu/packages/popt.scm \ > gnu/packages/pth.scm \ Instead of making a new module for this, how about adding it to web.scm? > diff --git a/gnu/packages/polipo.scm b/gnu/packages/polipo.scm > new file mode 100644 > index 0000000..9d01995 > --- /dev/null > +++ b/gnu/packages/polipo.scm > @@ -0,0 +1,60 @@ > +;;; GNU Guix --- Functional package management for GNU > +;;; Copyright =C2=A9 2014 Taylan Ulrich Bay=C4=B1rl=C4=B1/Kammer It's 2015 :) > +;;; > +;;; This file is part of GNU Guix. > +;;; > +;;; GNU Guix is free software; you can redistribute it and/or modify it > +;;; under the terms of the GNU General Public License as published by > +;;; the Free Software Foundation; either version 3 of the License, or (at > +;;; your option) any later version. > +;;; > +;;; GNU Guix is distributed in the hope that it will be useful, but > +;;; WITHOUT ANY WARRANTY; without even the implied warranty of > +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +;;; GNU General Public License for more details. > +;;; > +;;; You should have received a copy of the GNU General Public License > +;;; along with GNU Guix. If not, see . > + > +(define-module (gnu packages polipo) > + #:use-module (guix licenses) > + #:use-module (guix packages) > + #:use-module (guix download) > + #:use-module (guix build-system gnu) > + #:use-module (gnu packages texinfo)) > + > +(define-public polipo > + (package > + (name "polipo") > + (version "1.1.1") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "http://www.pps.univ-paris-diderot.fr/~jch/software/files/p= olipo/polipo-" > + version ".tar.gz")) > + (sha256 > + (base32 > + "05g09sg9qkkhnc2mxldm1w1xkxzs2ylybkjzs28w8ydbjc3pand2")))) > + (inputs `(("texinfo" ,texinfo))) Please change 'inputs' to 'native-inputs', because when cross-compiling, texinfo is needed on the build machine, not on the target. > + (build-system gnu-build-system) > + (arguments > + `(#:phases > + (alist-replace > + 'configure > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let ((out (assoc-ref outputs "out"))) > + (substitute* "Makefile" > + (("/usr/local") out) > + (("/usr/share") (string-append out "/share")))) > + (setenv "CC" "gcc")) > + %standard-phases) > + ;; No test suite. > + #:tests? #f)) How about this instead? (arguments `(#:make-flags (let ((out (assoc-ref %outputs "out"))) (list (string-append "PREFIX=3D" out) (string-append "LOCAL_ROOT=3D" out "/share/polipo/www") "CC=3Dgcc")) #:phases (alist-delete 'configure %standard-phases) #:tests? #f)) ; No test suite. > + (home-page "http://www.pps.univ-paris-diderot.fr/~jch/software/polip= o/") > + (synopsis "Small caching web proxy") > + (description > + "Polipo is a small caching web proxy (web cache, HTTP proxy, and pr= oxy > +server). It was primarily designed to be used by one person or a small = group > +of people.") > + (license (bsd-style "file://COPYING")))) This is the expat license, so just write (license expat). Can you send an updated patch? Thanks! Mark