Re: [PATCH] build-system: Add haskell-build-system.

[ludo@gnu.org (Ludovic Courtès)]

Federico Beffa <beffa@ieee.org> skribis:

> On Mon, Mar 30, 2015 at 10:16 AM, Ludovic Courtès <ludo@gnu.org> wrote:
>> Handling it during profile creation, as you suggest, and avoiding the
>> use of a wrapper sounds preferable to me.
>
> OK, lets go for that.

Sometime we’ll have to make info-dir + cert + ghc stuff in (guix
profiles) less adhoc.

> In the mean time I've found that to generate the documentation an
> additional step is required (phase haddock; the name is also the name
> of the tool used to generate the doc). I've added a keyword argument
> #:haddock? with default value of #t and #:haddock-flags for doc
> specific flags.

Nice.

> The documentation is in the form of html files and does seems to
> require a fair amount of space. Some random examples:
>
> - mtl libs: 1.2MB / doc: 0.772MB
> - text libs: 13MB / doc: 1.7MB
> - HTTP libs: 3.9MB / doc: 0.804MB
> - network-uri: libs: 1.5MB / doc: 0.168MB
> - parsec libs: 3.1MB / doc: 1.1MB
>
> Given that I'm starting to package a bunch of libraries, do we want to
> generate a separate output for all of them?

Probably, yes.

> From 87f567c0c3c06da73bd70e2498f7829258ae7d61 Mon Sep 17 00:00:00 2001
> From: Federico Beffa <beffa@fbengineering.ch>
> Date: Fri, 27 Mar 2015 09:36:56 +0100
> Subject: [PATCH 01/22] build-system: Add haskell-build-system.
>
> * guix/build-system/haskell.scm: New file.
> * guix/build/haskell-build-system.scm: New file.

[...]

> +;; - We generate the cache when a profile is created.
> +
> +;; Code:
> +;;

“Code:” should be “attached” to the block before and followed by an
empty line.

Please push, thank you!

Ludo’.