Re: [PATCH] gnu: Add python2-gnomekeyring.

[ludo@gnu.org (Ludovic Courtès)]

Ricardo Wurmus <rekado@elephly.net> skribis:

> the first patch defines a function to create packages from
> python2-gnome-desktop components and redefines python2-rsvg using this
> function.

Would it make sense to just have python2-gnome-desktop containing
everything, or would that be overkill?  (I suspect the latter, but I
want to make sure.)

> From 9045e6d296593a7f81269ecfab327733853b68f4 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Thu, 5 Mar 2015 08:38:13 +0100
> Subject: [PATCH 1/2] gnu: python2-rsvg: Define with helper function.
>
> * gnu/packages/gnome.scm (python2-gnome-desktop-component): New variable.

[...]

> +(define (python2-gnome-desktop-component comp syn desc ins lic)

Please spell out the argument names and add a docstring.

> +    (synopsis syn)
> +    (description desc)
> +    (license lic)))


[...]

> +(define-public python2-rsvg
> +  (python2-gnome-desktop-component
> +   "rsvg"
> +   "Python bindings to librsvg"
> +   "This module contains bindings allowing the use of librsvg in Python."

The problem is that xgettext won’t notice these.

A little bit of extra syntax is needed to placate it so that you can
write:

  (define-public python2-rsvg
    (python2-gnome-desktop-component
      "rsvg"
      (synopsis "Python bindings to librsvg")
      (description "This module contains bindings allowing the use of
librsvg in Python.")))

So let’s say:

  (define-syntax python2-gnome-desktop-component
    (syntax-rules (synopsis description)
      ((_ component (synopsis synopsis*) (description description*))
       (%python2-gnome-desktop-component component synopsis*
                                         description*))))

Where ‘%python2-gnome-desktop-component’ is the new name of the
procedure that this patch calls ‘python2-gnome-desktop-component’.

Really a hack, but hey, such is life.  ;-)

> From ba6cbc73f4ff3f1f5fc8e4ca26e867dc85291bd1 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Sun, 19 Apr 2015 18:59:01 +0200
> Subject: [PATCH 2/2] gnu: Add python2-gnomekeyring.
>
> * gnu/packages/gnome.scm (python2-gnomekeyring): New variable.

OK.

Thanks,
Ludo’.