[PATCH] gnu: Add sfxr.

[PATCH] gnu: Add sfxr.

[David Thompson]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-Add-sfxr.patch --]
[-- Type: text/x-diff, Size: 2704 bytes --]

From af67dcbcee6dfe218e8f3080551a213b5cc8eebd Mon Sep 17 00:00:00 2001
From: David Thompson <dthompson2@worcester.edu>
Date: Mon, 18 May 2015 19:14:01 -0400
Subject: [PATCH] gnu: Add sfxr.

* gnu/packages/game-development.scm (sfxr): New variable.
---
 gnu/packages/game-development.scm | 42 ++++++++++++++++++++++++++++++++++++++-
 1 file changed, 41 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
index 2191767..5941344 100644
--- a/gnu/packages/game-development.scm
+++ b/gnu/packages/game-development.scm
@@ -33,7 +33,11 @@
   #:use-module (gnu packages fontutils)
   #:use-module (gnu packages image)
   #:use-module (gnu packages audio)
-  #:use-module (gnu packages pulseaudio))
+  #:use-module (gnu packages pulseaudio)
+  #:use-module (gnu packages gnome)
+  #:use-module (gnu packages gtk)
+  #:use-module (gnu packages sdl)
+  #:use-module (gnu packages pkg-config))
 
 (define-public bullet
   (package
@@ -127,3 +131,39 @@ clone.")
 to ease the development of games and multimedia applications.  It is composed
 of five modules: system, window, graphics, audio and network.")
     (license license:zlib)))
+
+(define-public sfxr
+  (package
+    (name "sfxr")
+    (version "1.2.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://www.drpetter.se/files/sfxr-sdl-1.2.1.tar.gz"))
+              (sha256
+               (base32
+                "0dfqgid6wzzyyhc0ha94prxax59wx79hqr25r6if6by9cj4vx4ya"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases (modify-phases %standard-phases
+                  (delete 'configure) ; no configure script
+                  (add-before 'build 'patch-makefile
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let ((out (assoc-ref outputs "out")))
+                        (substitute* "Makefile"
+                          (("\\$\\(DESTDIR\\)/usr") out))
+                        (substitute* "main.cpp"
+                          (("/usr/share")
+                           (string-append out "/share")))))))
+       #:tests? #f)) ; no tests
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("desktop-file-utils" ,desktop-file-utils)))
+    (inputs
+     `(("sdl" ,sdl)
+       ("gtk+" ,gtk+)))
+    (synopsis "Simple sound effect generator")
+    (description "Sfxr is a tool for quickly generating simple sound effects.
+Originally created for use in video game prototypes, it can generate random
+sounds from presets such as \"explosion\" or \"powerup\".")
+    (home-page "http://www.drpetter.se/project_sfxr.html")
+    (license license:expat)))
-- 
2.1.4


[-- Attachment #2: Type: text/plain, Size: 38 bytes --]


-- 
David Thompson
GPG Key: 0FF1D807

Re: [PATCH] gnu: Add sfxr.

[Mark H Weaver]

Hi David,

David Thompson <dthompson2@worcester.edu> writes:

> From af67dcbcee6dfe218e8f3080551a213b5cc8eebd Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson2@worcester.edu>
> Date: Mon, 18 May 2015 19:14:01 -0400
> Subject: [PATCH] gnu: Add sfxr.
>
> * gnu/packages/game-development.scm (sfxr): New variable.
> ---
>  gnu/packages/game-development.scm | 42 ++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 41 insertions(+), 1 deletion(-)
>
>
> diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
> index 2191767..5941344 100644
> --- a/gnu/packages/game-development.scm
> +++ b/gnu/packages/game-development.scm
> @@ -33,7 +33,11 @@
>    #:use-module (gnu packages fontutils)
>    #:use-module (gnu packages image)
>    #:use-module (gnu packages audio)
> -  #:use-module (gnu packages pulseaudio))
> +  #:use-module (gnu packages pulseaudio)
> +  #:use-module (gnu packages gnome)
> +  #:use-module (gnu packages gtk)
> +  #:use-module (gnu packages sdl)
> +  #:use-module (gnu packages pkg-config))
>  
>  (define-public bullet
>    (package
> @@ -127,3 +131,39 @@ clone.")
>  to ease the development of games and multimedia applications.  It is composed
>  of five modules: system, window, graphics, audio and network.")
>      (license license:zlib)))
> +
> +(define-public sfxr
> +  (package
> +    (name "sfxr")
> +    (version "1.2.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://www.drpetter.se/files/sfxr-sdl-1.2.1.tar.gz"))
> +              (sha256
> +               (base32
> +                "0dfqgid6wzzyyhc0ha94prxax59wx79hqr25r6if6by9cj4vx4ya"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases (modify-phases %standard-phases
> +                  (delete 'configure) ; no configure script
> +                  (add-before 'build 'patch-makefile
> +                    (lambda* (#:key outputs #:allow-other-keys)
> +                      (let ((out (assoc-ref outputs "out")))
> +                        (substitute* "Makefile"
> +                          (("\\$\\(DESTDIR\\)/usr") out))
> +                        (substitute* "main.cpp"
> +                          (("/usr/share")
> +                           (string-append out "/share")))))))

Please add #t to the end of this phase procedure, since the return value
of 'substitute*' is not specified, and phase procedures are supposed to
return a boolean indicating success or failure.

Otherwise, it looks good to me!

    Thanks,
      Mark

Re: [PATCH] gnu: Add sfxr.

[David Thompson]

Mark H Weaver <mhw@netris.org> writes:

> Please add #t to the end of this phase procedure, since the return value
> of 'substitute*' is not specified, and phase procedures are supposed to
> return a boolean indicating success or failure.

Good catch.  Fixed and pushed!

-- 
David Thompson
GPG Key: 0FF1D807