* [PATCH] Add optional dependencies to ipython.
@ 2015-05-21 13:25 Ricardo Wurmus
2015-05-21 19:58 ` Ludovic Courtès
0 siblings, 1 reply; 5+ messages in thread
From: Ricardo Wurmus @ 2015-05-21 13:25 UTC (permalink / raw)
To: guix-devel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-python-ipython-Add-optional-dependencies.patch --]
[-- Type: text/x-patch, Size: 1392 bytes --]
From 9243823abad3943bd3f4ebe4f6d18cc53c2143e0 Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Date: Thu, 21 May 2015 15:24:11 +0200
Subject: [PATCH] gnu: python-ipython: Add optional dependencies.
* gnu/packages/python.scm (python-ipython)[inputs]: Add optional dependencies
"python-tornado" and "python-pyzmq".
---
gnu/packages/python.scm | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 5e4217a..9548d33 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -3016,13 +3016,15 @@ Python language binding specification.")
(base32 "1764gi5m3ff481rjk336cw6i2h4zlc0nxam9rc5m8m7yl9m4d61y"))))
(build-system python-build-system)
(outputs '("out" "doc"))
- ;; FIXME: add optional dependencies when available: pyzmq, tornado, ...
+ ;; FIXME: add optional dependencies when available: pexpect
(inputs
`(("readline" ,readline)
("python-matplotlib" ,python-matplotlib)
("python-numpy" ,python-numpy-bootstrap)
("python-numpydoc" ,python-numpydoc)
- ("python-nose" ,python-nose)))
+ ("python-nose" ,python-nose)
+ ("python-tornado" ,python-tornado)
+ ("python-pyzmq" ,python-pyzmq)))
(native-inputs
`(("pkg-config" ,pkg-config)
("python-sphinx" ,python-sphinx)
--
2.1.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Add optional dependencies to ipython.
2015-05-21 13:25 [PATCH] Add optional dependencies to ipython Ricardo Wurmus
@ 2015-05-21 19:58 ` Ludovic Courtès
2015-05-27 8:20 ` Ricardo Wurmus
0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2015-05-21 19:58 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: guix-devel
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
> From 9243823abad3943bd3f4ebe4f6d18cc53c2143e0 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Thu, 21 May 2015 15:24:11 +0200
> Subject: [PATCH] gnu: python-ipython: Add optional dependencies.
>
> * gnu/packages/python.scm (python-ipython)[inputs]: Add optional dependencies
> "python-tornado" and "python-pyzmq".
LGTM. One question though: how much does it add to the ipython’s
closure size, and is it something that many ipython users would have
little use for?
IOW, the popularity/extra-space ratio should be greater than one. :-)
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Add optional dependencies to ipython.
2015-05-21 19:58 ` Ludovic Courtès
@ 2015-05-27 8:20 ` Ricardo Wurmus
2015-05-27 15:28 ` Ludovic Courtès
0 siblings, 1 reply; 5+ messages in thread
From: Ricardo Wurmus @ 2015-05-27 8:20 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
>> From 9243823abad3943bd3f4ebe4f6d18cc53c2143e0 Mon Sep 17 00:00:00 2001
>> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
>> Date: Thu, 21 May 2015 15:24:11 +0200
>> Subject: [PATCH] gnu: python-ipython: Add optional dependencies.
>>
>> * gnu/packages/python.scm (python-ipython)[inputs]: Add optional dependencies
>> "python-tornado" and "python-pyzmq".
>
> LGTM. One question though: how much does it add to the ipython’s
> closure size, and is it something that many ipython users would have
> little use for?
>
> IOW, the popularity/extra-space ratio should be greater than one. :-)
Before the patch:
du -ms $(guix gc -R \
/gnu/store/frjwvppazzjvp7pzwfawa9nrq1nx135q-python-ipython-2.3.1) | \
cut -f1 | paste -s -d+ | bc
==> 683 MB
After the patch:
du -ms $(guix gc -R \
/gnu/store/bqpmsh45fzmjynczcwx6zvycinf7c91r-python-ipython-2.3.1) | \
cut -f1 | paste -s -d+ | bc
==> 765 MB
I don't know if support for python-tornado and python-pyzmq in
python-ipython is worth an additional 82 MB.
It was only after I packaged python-tornado and python-pyzmq for other
purposes that I noticed that python-ipython takes it as an optional
input, so I added it. (Personally, I don't need it because I'm not an
IPython user.)
~~ Ricardo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Add optional dependencies to ipython.
2015-05-27 8:20 ` Ricardo Wurmus
@ 2015-05-27 15:28 ` Ludovic Courtès
0 siblings, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2015-05-27 15:28 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: guix-devel
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
>>> From 9243823abad3943bd3f4ebe4f6d18cc53c2143e0 Mon Sep 17 00:00:00 2001
>>> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
>>> Date: Thu, 21 May 2015 15:24:11 +0200
>>> Subject: [PATCH] gnu: python-ipython: Add optional dependencies.
>>>
>>> * gnu/packages/python.scm (python-ipython)[inputs]: Add optional dependencies
>>> "python-tornado" and "python-pyzmq".
>>
>> LGTM. One question though: how much does it add to the ipython’s
>> closure size, and is it something that many ipython users would have
>> little use for?
>>
>> IOW, the popularity/extra-space ratio should be greater than one. :-)
[...]
> I don't know if support for python-tornado and python-pyzmq in
> python-ipython is worth an additional 82 MB.
My guess is that no, it’s not worth it. So let’s leave it this way,
maybe adding a comment to the future reader who wonders why these two
are missing.
Now, 683 MiB is already a lot, and it would be interesting to analyze
why it’s so big.
Thanks!
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] Add optional dependencies to ipython.
@ 2015-07-18 9:25 Federico Beffa
0 siblings, 0 replies; 5+ messages in thread
From: Federico Beffa @ 2015-07-18 9:25 UTC (permalink / raw)
To: ricardo.wurmus, Ludovic Courtès; +Cc: Guix-devel
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:
> From 9243823abad3943bd3f4ebe4f6d18cc53c2143e0 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Thu, 21 May 2015 15:24:11 +0200
> Subject: [PATCH] gnu: python-ipython: Add optional dependencies.
>
> * gnu/packages/python.scm (python-ipython)[inputs]: Add optional dependencies
> "python-tornado" and "python-pyzmq".
> ---
> gnu/packages/python.scm | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 5e4217a..9548d33 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -3016,13 +3016,15 @@ Python language binding specification.")
> (base32 "1764gi5m3ff481rjk336cw6i2h4zlc0nxam9rc5m8m7yl9m4d61y"))))
> (build-system python-build-system)
> (outputs '("out" "doc"))
> - ;; FIXME: add optional dependencies when available: pyzmq, tornado, ...
> + ;; FIXME: add optional dependencies when available: pexpect
> (inputs
> `(("readline" ,readline)
> ("python-matplotlib" ,python-matplotlib)
> ("python-numpy" ,python-numpy-bootstrap)
> ("python-numpydoc" ,python-numpydoc)
> - ("python-nose" ,python-nose)))
> + ("python-nose" ,python-nose)
> + ("python-tornado" ,python-tornado)
> + ("python-pyzmq" ,python-pyzmq)))
> (native-inputs
> `(("pkg-config" ,pkg-config)
> ("python-sphinx" ,python-sphinx)
I would welcome such additions because Emacs' org-mode doesn't work
well with ipython and a recent improvement on that requires these
additions.
https://github.com/gregsexton/ob-ipython
Regards,
Fede
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-07-18 9:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-21 13:25 [PATCH] Add optional dependencies to ipython Ricardo Wurmus
2015-05-21 19:58 ` Ludovic Courtès
2015-05-27 8:20 ` Ricardo Wurmus
2015-05-27 15:28 ` Ludovic Courtès
-- strict thread matches above, loose matches on Subject: below --
2015-07-18 9:25 Federico Beffa
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.