From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: [PATCHES] Add totem
Date: Wed, 24 Jun 2015 02:06:35 -0400
Message-ID: <878ub9k5ck.fsf@netris.org>
References: <87d20padyz.fsf@netris.org> <87pp4na6me.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58362)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1Z7dpf-0007Oc-5S
	for guix-devel@gnu.org; Wed, 24 Jun 2015 02:06:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1Z7dpb-0003cH-4l
	for guix-devel@gnu.org; Wed, 24 Jun 2015 02:06:47 -0400
In-Reply-To: <87pp4na6me.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Mon, 22 Jun 2015 21:24:41 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

ludo@gnu.org (Ludovic Court=C3=A8s) writes:

>> From ba786fa3d1d7896336dca3b364bb630142c30fa1 Mon Sep 17 00:00:00 2001
>> From: Mark H Weaver <mhw@netris.org>
>> Date: Sat, 20 Jun 2015 21:09:54 -0400
>> Subject: [PATCH 2/3] gnu: Add grilo-plugins.
>>
>> * gnu/packages/gnome.scm (grilo-plugins): New variable.
>
> [...]
>
>> +     `(#:make-flags (list (string-append "GRL_PLUGINS_DIR=3D"
>> +                                         %output
>> +                                         "/lib/grilo-"
>> +                                         ,(version-major+minor version)=
))
>> +       ;; XXX FIXME: Investigate test failure:
>> +       ;;   TEST: test_apple_trailers... (pid=3D8718)
>> +       ;;     /apple-trailers/browse/count:
>> +       ;;   ERROR:test_apple_trailers.c:88:test_browse_count: assertion=
 failed: (source)
>> +       ;;   FAIL
>> +       #:tests? #f))
>
> Would it be OK to skip just this for now?  If that=E2=80=99s too much, we=
 can
> leave it for later.

"make check" aborts after this failure, which is the first test.  I
tried "make -k check" and found that _all_ tests fail with the same
assertion failure when run in the build container.

However, if I run "make -k check" on the failed build directory in
/tmp/nix-build-* from outside of the build container, all but one of the
tests succeeds.  This when using the precise environment variable
settings from the build and no others.  Using strace, I found that it
was accessing the system dbus, so I guess that's the problem.

>> +    (synopsis "Framework for discovering and browsing media - Plugins")
>
> Maybe =E2=80=9CPlugins for the Grilo media discovery library=E2=80=9D?

Yes, that's better, thanks!

I'm going to hold off on pushing grilo{-plugins} and totem until the
'nettle-fix' branch is merged (it fixes gst-libav on x86_64), and also
to get more feedback on how best to handle totem's required plugins and
dbus services.

      Thanks,
        Mark