From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Subject: Re: [PATCH 6/7] gnu: Add elogind service.
Date: Fri, 21 Aug 2015 22:17:10 +0800
Message-ID: <878u94n2u1.fsf@gmail.com>
References: <1439894067.158090.5302@rusty>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55678)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@gmail.com>) id 1ZSn77-00074y-9P
	for guix-devel@gnu.org; Fri, 21 Aug 2015 10:16:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <iyzsong@gmail.com>) id 1ZSn73-0000AP-1l
	for guix-devel@gnu.org; Fri, 21 Aug 2015 10:16:12 -0400
Received: from mail-pa0-x22c.google.com ([2607:f8b0:400e:c03::22c]:33933)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@gmail.com>) id 1ZSn72-00009s-Rm
	for guix-devel@gnu.org; Fri, 21 Aug 2015 10:16:08 -0400
Received: by padfo6 with SMTP id fo6so8196635pad.1
	for <guix-devel@gnu.org>; Fri, 21 Aug 2015 07:16:08 -0700 (PDT)
In-Reply-To: <1439894067.158090.5302@rusty>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Andy Wingo <wingo@igalia.com>, guix-devel@gnu.org

Andy Wingo <wingo@igalia.com> writes:

> * gnu/services/desktop.scm (elogind-service): New function.
>   (%desktop-services): Add elogind-service.
> ---
>  gnu/services/desktop.scm | 27 ++++++++++++++++++++++++++-
>  1 file changed, 26 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
> index 4e4b49d..737a734 100644
> --- a/gnu/services/desktop.scm
> +++ b/gnu/services/desktop.scm
> @@ -26,6 +26,7 @@
>    #:use-module (gnu system shadow)
>    #:use-module (gnu packages glib)
>    #:use-module (gnu packages admin)
> +  #:use-module (gnu packages freedesktop)
>    #:use-module (gnu packages gnome)
>    #:use-module (gnu packages avahi)
>    #:use-module (gnu packages wicd)
> @@ -39,6 +40,7 @@
>              geoclue-application
>              %standard-geoclue-applications
>              geoclue-service
> +            elogind-service
>              %desktop-services))
>  
>  ;;; Commentary:
> @@ -374,6 +376,28 @@ site} for more information."
>  
>  
>  ;;;
> +;;; Elogind login and seat management service.
> +;;;
> +
> +(define* (elogind-service #:key (elogind elogind))
> +  "Return a service that runs the @command{elogind} login and seat management
> +service.  The @command{elogind} service integrates with PAM to allow other
> +system components to know the set of logged-in users as well as their session
> +types (graphical, console, remote, etc.).  It can also clean up after users
> +when they log out."
> +  (with-monad %store-monad
> +    (return
> +     (service
> +      (documentation "Run the elogind login and seat management service.")
> +      (provision '(elogind))
> +      (requirement '(dbus-system))
> +
> +      (start #~(make-forkexec-constructor
> +                (list (string-append #$elogind
>  "/lib/elogind/elogind"))))
Should be "/libexec/elogind/elogind".
> +      (stop #~(make-kill-destructor))))))
> +
> +
> +;;;
>  ;;; The default set of desktop services.
>  ;;;
>  (define %desktop-services
> @@ -389,7 +413,8 @@ site} for more information."
>           ;; time, so we currently add them to the set of default services.
>           (colord-service)
>           (geoclue-service)
> -         (dbus-service (list avahi wicd upower colord geoclue))
> +         (elogind-service)
> +         (dbus-service (list avahi wicd upower colord geoclue elogind))
>  
>           (ntp-service)
>  
> -- 
> 2.4.3
Look good to me!