From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: openblas: Fix configure flags on armhf and take
	target
Date: Thu, 01 Oct 2015 22:50:48 +0200
Message-ID: <878u7mmhxz.fsf@gnu.org>
References: <20151001084613.GA6497@debian> <87twqar0c8.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48334)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zhkoa-0006Yu-Gu
	for guix-devel@gnu.org; Thu, 01 Oct 2015 16:51:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZhkoV-0005xG-HG
	for guix-devel@gnu.org; Thu, 01 Oct 2015 16:50:56 -0400
In-Reply-To: <87twqar0c8.fsf@netris.org> (Mark H. Weaver's message of "Thu, 01
	Oct 2015 12:59:51 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org

Mark H Weaver <mhw@netris.org> skribis:

> Andreas Enge <andreas@enge.fr> writes:

[...]

>> +        ,(let ((system (or (%current-target-system) (%current-system))))
>> +           (or (string-prefix? "x86_64" system)
>> +               (string-prefix? "i686" system)))
>
> It's not your fault, but the fact that (%current-system) returns a
> "system" string (e.g. "mips64el-linux") but (%current-target-system)
> returns a GNU triplet (e.g. "mips64el-unknown-linux-gnu") is very
> confusing.  The fact that we use (or (%current-target-system)
> (%current-system)) in many places, and name variables like the one
> above "system" reinforces that confusion.
>
> To mitigate this, how about renaming the variable above to
> 'system-or-triplet'?

I think for a local variable keeping =E2=80=98system=E2=80=99 is OK.  Howev=
er, what
about renaming =E2=80=98%current-target-system=E2=80=99 to =E2=80=98%curren=
t-target-triplet=E2=80=99?
That may help a bit.

> Another possible issue is that our Hurd port seems to use "i586" in
> several places.  I'm not sure if we have to check for that as well.
> Maybe we need a helper procedure to check for Intel systems.

Yes, good idea.

Ludo=E2=80=99.