Re: [PATCH] gnu: openblas: Fix configure flags on armhf and take target

[ludo@gnu.org (Ludovic Courtès)]

Mark H Weaver <mhw@netris.org> skribis:

> Andreas Enge <andreas@enge.fr> writes:

[...]

>> +        ,(let ((system (or (%current-target-system) (%current-system))))
>> +           (or (string-prefix? "x86_64" system)
>> +               (string-prefix? "i686" system)))
>
> It's not your fault, but the fact that (%current-system) returns a
> "system" string (e.g. "mips64el-linux") but (%current-target-system)
> returns a GNU triplet (e.g. "mips64el-unknown-linux-gnu") is very
> confusing.  The fact that we use (or (%current-target-system)
> (%current-system)) in many places, and name variables like the one
> above "system" reinforces that confusion.
>
> To mitigate this, how about renaming the variable above to
> 'system-or-triplet'?

I think for a local variable keeping ‘system’ is OK.  However, what
about renaming ‘%current-target-system’ to ‘%current-target-triplet’?
That may help a bit.

> Another possible issue is that our Hurd port seems to use "i586" in
> several places.  I'm not sure if we have to check for that as well.
> Maybe we need a helper procedure to check for Intel systems.

Yes, good idea.

Ludo’.