From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Add r-devtools.
Date: Sun, 15 Nov 2015 21:32:04 +0100
Message-ID: <878u5zt35n.fsf@gnu.org>
References: <idjr3jwd6gu.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54209)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zy3y6-0007A8-Gy
	for guix-devel@gnu.org; Sun, 15 Nov 2015 15:32:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zy3y2-00034Y-H2
	for guix-devel@gnu.org; Sun, 15 Nov 2015 15:32:10 -0500
In-Reply-To: <idjr3jwd6gu.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's
	message of "Wed, 11 Nov 2015 14:13:37 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> The git2r README says this:
>
>   The libgit2 library has been modified, e.g. to use the R printing and
>   error routines, and to use runif instead of rand.
>
> In other places it says that libgit2 was modified to build it as an R
> package.  As I don=E2=80=99t know what this means I=E2=80=99ve submitted =
a bug report to
> ask if linking against an external libgit2 would be possible:
>
>   https://github.com/ropensci/git2r/issues/187
>
> I also added a note to the package recipe stating that the package
> contains modified sources of libgit2.

Sounds good.  It=E2=80=99s great that you took the time to check with upstr=
eam.

> From 853cd47952dad86f69d7ed9389174cc77eed17e9 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Wed, 11 Nov 2015 14:07:24 +0100
> Subject: [PATCH 1/3] gnu: Add r-git2r.
>
> * gnu/packages/statistics.scm (r-git2r): New variable.

[...]

> +    (synopsis "Access git repositories with R")

s/git/Git/

Otherwise LGTM.

> From a8df74bb8cfc34b5ea0f62b56f8fa9ede46c622c Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Wed, 11 Nov 2015 14:07:47 +0100
> Subject: [PATCH 2/3] gnu: Add r-rstudioapi.
>
> * gnu/packages/statistics.scm (r-rstudioapi): New variable.

LGTM.

> From 9491af491f85afe7f317309946cea34f63af8221 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Wed, 11 Nov 2015 14:08:46 +0100
> Subject: [PATCH 3/3] gnu: Add r-devtools.
>
> * gnu/packages/statistics.scm (r-devtools): New variable.

LGTM.

Thanks!

Ludo=E2=80=99.