From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: parted: Update to 3.2.
Date: Sat, 21 Nov 2015 11:24:52 +0100
Message-ID: <878u5rd4zv.fsf@gnu.org>
References: <87wptc2nv1.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37738)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1a05Ll-0001jR-Rd
	for guix-devel@gnu.org; Sat, 21 Nov 2015 05:24:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1a05Li-0004yp-O3
	for guix-devel@gnu.org; Sat, 21 Nov 2015 05:24:57 -0500
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54532)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1a05Li-0004yl-Kd
	for guix-devel@gnu.org; Sat, 21 Nov 2015 05:24:54 -0500
In-Reply-To: <87wptc2nv1.fsf@gnu.org> (Mathieu Lirzin's message of "Sat, 21
	Nov 2015 01:32:50 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Mathieu Lirzin <mthl@gnu.org>
Cc: guix-devel@gnu.org

Mathieu Lirzin <mthl@gnu.org> skribis:

> From a43f69d7f57df7ca2fb156ab75a845a68cc43d02 Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <mthl@gnu.org>
> Date: Sat, 21 Nov 2015 01:07:03 +0100
> Subject: [PATCH] gnu: parted: Update to 3.2.
>
> * gnu/packages/disk.scm (parted): Update to 3.2.
> [inputs]: Add lvm2 and remove check.  Replace readline-6.2 with its
> latest version.
> [native-inputs]: Add perl and python for the tests.
> [arguments]: Use `modify-phases' and adapt to the new tests.
> [home-page]: Use https.

Thanks for tackling this.  I think the reason this wasn=E2=80=99t done befo=
re is
that there were various issues, notably:

  https://lists.gnu.org/archive/html/bug-parted/2014-08/msg00001.html
  https://lists.gnu.org/archive/html/bug-parted/2014-08/msg00002.html

and then I dropped the ball.  :-)

> +                      (substitute* "tests/t0251-gpt-unicode.sh"
> +                        (("C.UTF-8") "en_US.UTF-8")) ;not in Glibc local=
es

Rather =E2=80=9Cen_US.utf8=E2=80=9D, because =E2=80=9Cutf8=E2=80=9D is the =
=E2=80=9Cnormalized codeset=E2=80=9D.

> +    (inputs `(("lvm2"       ,lvm2)
> +              ("readline"   ,readline)
> +              ("util-linux" ,util-linux)))

I=E2=80=99d prefer to avoid this alignment style.  No big deal though.

OK with the above change, thank you!

Ludo=E2=80=99.