all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Mathieu Lirzin <mthl@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: parted: Update to 3.2.
Date: Sat, 21 Nov 2015 11:24:52 +0100	[thread overview]
Message-ID: <878u5rd4zv.fsf@gnu.org> (raw)
In-Reply-To: <87wptc2nv1.fsf@gnu.org> (Mathieu Lirzin's message of "Sat, 21 Nov 2015 01:32:50 +0100")

Mathieu Lirzin <mthl@gnu.org> skribis:

> From a43f69d7f57df7ca2fb156ab75a845a68cc43d02 Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <mthl@gnu.org>
> Date: Sat, 21 Nov 2015 01:07:03 +0100
> Subject: [PATCH] gnu: parted: Update to 3.2.
>
> * gnu/packages/disk.scm (parted): Update to 3.2.
> [inputs]: Add lvm2 and remove check.  Replace readline-6.2 with its
> latest version.
> [native-inputs]: Add perl and python for the tests.
> [arguments]: Use `modify-phases' and adapt to the new tests.
> [home-page]: Use https.

Thanks for tackling this.  I think the reason this wasn’t done before is
that there were various issues, notably:

  https://lists.gnu.org/archive/html/bug-parted/2014-08/msg00001.html
  https://lists.gnu.org/archive/html/bug-parted/2014-08/msg00002.html

and then I dropped the ball.  :-)

> +                      (substitute* "tests/t0251-gpt-unicode.sh"
> +                        (("C.UTF-8") "en_US.UTF-8")) ;not in Glibc locales

Rather “en_US.utf8”, because “utf8” is the “normalized codeset”.

> +    (inputs `(("lvm2"       ,lvm2)
> +              ("readline"   ,readline)
> +              ("util-linux" ,util-linux)))

I’d prefer to avoid this alignment style.  No big deal though.

OK with the above change, thank you!

Ludo’.

  reply	other threads:[~2015-11-21 10:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-21  0:32 [PATCH] gnu: parted: Update to 3.2 Mathieu Lirzin
2015-11-21 10:24 ` Ludovic Courtès [this message]
2015-11-21 12:32   ` Mathieu Lirzin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878u5rd4zv.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=mthl@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.