From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 3/3] system: pam: Honor /etc/environment.
Date: Fri, 04 Dec 2015 15:38:18 +0100
Message-ID: <878u5ajn39.fsf@gnu.org>
References: <1449063511-689-1-git-send-email-iyzsong@gmail.com>
	<1449063511-689-3-git-send-email-iyzsong@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58462)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1a4yX1-0002DZ-Oe
	for guix-devel@gnu.org; Fri, 04 Dec 2015 17:08:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1a4yX0-0005Yn-Ul
	for guix-devel@gnu.org; Fri, 04 Dec 2015 17:08:47 -0500
In-Reply-To: <1449063511-689-3-git-send-email-iyzsong@gmail.com>
	(=?utf-8?B?IuWui+aWh+atpiIncw==?=
	message of "Wed, 2 Dec 2015 21:38:31 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Cc: guix-devel@gnu.org

=E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:

> * gnu/system/pam.scm (unix-pam-service): Add pam_env module to the sessio=
n group.

[...]

> +        (env  (pam-entry
> +               (control "required")
> +               (module "pam_env.so"))))

Please mention /etc/environment above.

Otherwise LGTM, thank you!

This patch is OK for now, but we should soon arrange it so that
=E2=80=98session-environment-service=E2=80=99 extends =E2=80=98pam-root-ser=
vice-type=E2=80=99 in a way
that adds =E2=80=98pam_env=E2=80=99 to the session management group of all =
the PAM
services.

This could be done by extending =E2=80=98pam-root-service-type=E2=80=99 wit=
h a
procedure.  That procedure would automatically be mapped over all the
PAM services to compute the final PAM services.

The same approach could then be used for pam_elogind.

Thoughts?

Ludo=E2=80=99.