From: ludo@gnu.org (Ludovic Courtès)
To: 宋文武 <iyzsong@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 3/3] system: pam: Honor /etc/environment.
Date: Fri, 04 Dec 2015 15:38:18 +0100 [thread overview]
Message-ID: <878u5ajn39.fsf@gnu.org> (raw)
In-Reply-To: <1449063511-689-3-git-send-email-iyzsong@gmail.com> ("宋文武"'s message of "Wed, 2 Dec 2015 21:38:31 +0800")
宋文武 <iyzsong@gmail.com> skribis:
> * gnu/system/pam.scm (unix-pam-service): Add pam_env module to the session group.
[...]
> + (env (pam-entry
> + (control "required")
> + (module "pam_env.so"))))
Please mention /etc/environment above.
Otherwise LGTM, thank you!
This patch is OK for now, but we should soon arrange it so that
‘session-environment-service’ extends ‘pam-root-service-type’ in a way
that adds ‘pam_env’ to the session management group of all the PAM
services.
This could be done by extending ‘pam-root-service-type’ with a
procedure. That procedure would automatically be mapped over all the
PAM services to compute the final PAM services.
The same approach could then be used for pam_elogind.
Thoughts?
Ludo’.
next prev parent reply other threads:[~2015-12-04 22:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 13:38 [PATCH 1/3] services: Add 'session-environment-service' 宋文武
2015-12-02 13:38 ` [PATCH 2/3] system: Add /etc/environment 宋文武
2015-12-04 14:33 ` Ludovic Courtès
2015-12-05 2:55 ` 宋文武
2015-12-02 13:38 ` [PATCH 3/3] system: pam: Honor /etc/environment 宋文武
2015-12-04 14:38 ` Ludovic Courtès [this message]
2015-12-02 18:45 ` [PATCH 1/3] services: Add 'session-environment-service' Alex Kost
2015-12-03 11:59 ` 宋文武
2015-12-04 14:29 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878u5ajn39.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=iyzsong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.