From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Add libgit2.
Date: Mon, 21 Dec 2015 14:37:12 +0100
Message-ID: <878u4nncs7.fsf@gnu.org>
References: <idj8u4t6pdq.fsf@bimsb-sys02.mdc-berlin.net>
	<87mvt61quk.fsf@gnu.org> <idjtwnc5btm.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42039)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aB0eM-0003BZ-EI
	for guix-devel@gnu.org; Mon, 21 Dec 2015 08:37:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aB0eJ-0000hY-7o
	for guix-devel@gnu.org; Mon, 21 Dec 2015 08:37:18 -0500
In-Reply-To: <idjtwnc5btm.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's
	message of "Mon, 21 Dec 2015 11:35:17 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
>>
>>> The tests only fail when run with =E2=80=9Cguix build=E2=80=9D.
>>> I run them like this:
>>>
>>>     ./libgit2_clar -v -Q
>>>
>>> And I get erros like this:
>>>
>>>    Function call failed: (chdir(sandbox))
>>>       error -1 - <no message>
>>
>> Does the test also fail outside the build environment?  Could you strace
>> it to see exactly what the argument to =E2=80=98chdir=E2=80=99 is and wh=
at its errno
>> value is?
>>
>> At first sight it sounds like it should be fixable, so it=E2=80=99s wort=
h a try.
>
> It was fixable!  (I seem to have to give up first before eventually
> succeeding.)

Cool!

> From 973a38bc00343863ea61d7345661281b84ac4ce7 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Thu, 17 Dec 2015 16:20:05 +0100
> Subject: [PATCH] gnu: Add libgit2.
>
> * gnu/packages/version-control.scm (libgit2): New variable.

LGTM, thank you!

Ludo=E2=80=99.