From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Marusich Subject: Re: Patches to add s3cmd and python-magic Date: Mon, 28 Mar 2016 22:37:48 -0700 Message-ID: <878u11rgib.fsf@gmail.com> References: <87io071dqo.fsf@gmail.com> <20160328223542.5c66e67e@scratchpost.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45434) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akmLp-0005Q2-UN for guix-devel@gnu.org; Tue, 29 Mar 2016 01:38:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akmLl-0004iT-UV for guix-devel@gnu.org; Tue, 29 Mar 2016 01:38:01 -0400 Received: from mail-pf0-x22a.google.com ([2607:f8b0:400e:c00::22a]:34268) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akmLl-0004iF-KF for guix-devel@gnu.org; Tue, 29 Mar 2016 01:37:57 -0400 Received: by mail-pf0-x22a.google.com with SMTP id x3so6071963pfb.1 for ; Mon, 28 Mar 2016 22:37:56 -0700 (PDT) In-Reply-To: <20160328223542.5c66e67e@scratchpost.org> (Danny Milosavljevic's message of "Mon, 28 Mar 2016 22:35:42 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Danny Milosavljevic Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Danny Milosavljevic writes: >> * Do I need to provide setuptools as a native input, or will it be >> pulled in automatically? > > I think you need to provide it. Try removing it. Does your package still = build? When I remove setuptools as a native input, the build for python-magic succeeds, but fails for python2-magic. I guess it's getting pulled in implicitly in one case, but not the other. Either way, I think it makes sense to declare the dependency explicitly as a native input. > As for the cross-compiling, you're right, I don't think it's important in= this case.=20 > > However, I think for documentation purposes it would still be nice to > see which of the things are required only for the build (the native > inputs - after all, they wouldn't work at runtime in general). That makes sense. Thanks for explaining. >> * In the package definition for python2-s3cmd, should python2-magic be a >> propagated input instead of a regular input? It seems to work as a >> normal input, so I think the answer is "no", but I understand that >> sometimes this matters for python packages. > > If it works as a regular input, that's even better, so keep it only as re= gular input. Unfortunately, that's very seldom. It works as a regular input. It seems that it works as a regular input because the s3cmd program is wrapped using the wrap-program procedure From=20guix/build/utils.scm, which the python-build-system uses to set up the PYTHONPATH appropriately. > When testing s3cmd, make sure that python2-magic is not in your > profile (for example installed manually via guix package -i > python2-magic). Good call. I did this, and I can confirm that it works even when python2-magic is not installed in my profile. Thank you for the feedback! =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJW+hSuAAoJEN1AmhXYIkadSj8P/1MJNBwXYv1j+YACxWSDcp5L 9+F2eLf02z11Pkc0EWL8ZxasChd/Tq2IPJ/ao0oB2bR2s1cVWhfbRKPLmZQw6Ezc CKgS+NuMTnqR7XUI3aYqDQ7Lq2E7FBawgrIyNjvA3RpNU9Q7L9EAd4XkPEEM9bLK JO/UKGp8A7lQLDpQx/UQNx/nl8xFVQ7Q/8gwMQw34Y4MyR6Qz7Sb5PZ8gt2Fcwvf 6qpA3RIwcfSq6Wb742050elx0i2aDaFZngMlVsJW7TOYuuSnCu4I0qqNWk2nmZTC TjLusNVnqemytQ2RZZEcREFqzan+2R/tFQIWv8VD/Pp0Dgc1nmMf1/pijmEOpg64 wASj/y2UM3ejY1QajCQxNUGkqNXFAOLvhazF9ka4ThklErxl5snL3j7bKk6ECBtv ZB/G/FKABJX4zv+H1fqaZFxzn1QDlrexUKZGRBz2XwOxqPZpUn63vUynoGFOoKt0 wjR9Gw7T+EsuWsKcYH3DfLqC2S64tvqJ7SfoeVkbMhWlxip1cci88Sg7sZFrzJth xv2vmjDXOHPzP8Lv955BpvbconLSjNuYZ3YKIQAvTa87/ZSa0JvOj3ZNhNBzCU7D ewTgvgOTG51uYaewXyH88Z7g7XfNqnKrVoQjTdYkopEA6UPa90478AJEd9yeI9qi 3Ve2q35YDnUlF0L+T/Rx =wSrH -----END PGP SIGNATURE----- --=-=-=--