Re: [PATCH] gnu: Add gnome-calendar.

[Ricardo Wurmus <rekado@elephly.net>]

Hi,

thank you for the patch!

> Note that this package is nonfunctional without first applying the
> libical patch I sent earlier.


> From 29033622d9490d299d2409b73f9e21862ca939ec Mon Sep 17 00:00:00 2001
> From: Kei Yamashita <kei@openmailbox.org>
> Date: Tue, 10 May 2016 00:16:46 -0400
> Subject: [PATCH] gnu: Add gnome-calendar.

> * gnu/packages/gnome.scm (gnome-calendar): New variable.
> ---
>  gnu/packages/gnome.scm | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)

> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 0fd1d5b..0274f20 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -4995,3 +4995,32 @@ specified duration and save it as a GIF encoded animated image file.")
>       "Libzapojit is a GLib-based library for accessing online service APIs of
>  Microsoft SkyDrive and Hotmail, using their REST protocols.")
>      (license license:lgpl2.1+)))
> +
> +(define-public gnome-calendar
> +  (package
> +    (name "gnome-calendar")
> +    (version "3.18.3")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://gnome/sources/" name "/"
> +                                  (version-major+minor version) "/"
> +                                  name "-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "0xcmhzz3lfy9sx2ff2krjdhcrhmapgn8nssbwlcfrb15jw2pcnyv"))))
> +    (build-system glib-or-gtk-build-system)
> +    (native-inputs
> +     `(("intltool" ,intltool)
> +       ("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("bdb" ,bdb)
> +       ("desktop-file-utils" ,desktop-file-utils)
> +       ("evolution-data-server" ,evolution-data-server)
> +       ("gnome-online-accounts" ,gnome-online-accounts)))
> +    (home-page "https://wiki.gnome.org/Apps/Calendar")
> +    (synopsis "Calendar application designed to fit GNOME desktop")

I think “to fit *the* GNOME desktop” might be better.

> +    (description
> +     "GNOME Calendar is a simple and beautiful calendar application designed to
> +perfectly fit the GNOME desktop.  By reusing the components which the GNOME
> +desktop is build on, Calendar nicely integrates with the GNOME ecosystem.")
> +    (license license:gpl3+)))
> -- 
> 2.7.4

The description is a bit shallow, in my opinion.  Both sentences say
that it fits the GNOME deskop, and part of the first sentence says it’s
“beautiful”.  I don’t have strong objections to this description, but I
think we could do better.

(I also don’t really like the word “ecosystem” in this context.)

Otherwise this looks very good to me.  (NOTE: I haven’t built the
package myself.)

~~ Ricardo