From mboxrd@z Thu Jan  1 00:00:00 1970
From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=)
Subject: Re: [PATCH] gnu: add vte-ng
Date: Wed, 01 Jun 2016 21:30:25 +0800
Message-ID: <878typt4su.fsf@member.fsf.org>
References: <CAM5ENzAzZVnHi1Uv3F6JGVuF0Ju7PNUQ8_BrEHmHWG6rEbumCg@mail.gmail.com>
	<87zitfws0r.fsf@gmail.com> <87wpo7rx5g.fsf@gmail.com>
	<CAM5ENzCezyQd9xniEPrMTf9PCviqBcDwqKt+0OLR+5ybFXZgww@mail.gmail.com>
	<871t6d7vv9.fsf@gmail.com>
	<CAM5ENzC2_haphhuR5qCRJi-+qqMSTxZ72Suerpn-4ooc9TBVEQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59203)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@openmailbox.org>) id 1b86EM-0001aG-05
	for guix-devel@gnu.org; Wed, 01 Jun 2016 09:30:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <iyzsong@openmailbox.org>) id 1b86EI-0005Wt-Pg
	for guix-devel@gnu.org; Wed, 01 Jun 2016 09:30:41 -0400
Received: from mail.openmailbox.org ([62.4.1.34]:48327)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@openmailbox.org>) id 1b86EI-0005Wl-J5
	for guix-devel@gnu.org; Wed, 01 Jun 2016 09:30:38 -0400
In-Reply-To: <CAM5ENzC2_haphhuR5qCRJi-+qqMSTxZ72Suerpn-4ooc9TBVEQ@mail.gmail.com>
	(Mckinley Olsen's message of "Tue, 31 May 2016 14:41:02 -0600")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Mckinley Olsen <mck.olsen@gmail.com>
Cc: guix-devel@gnu.org, Alex Kost <alezost@gmail.com>

Mckinley Olsen <mck.olsen@gmail.com> writes:

> Hey Alex, I'm hoping this patch is up to snuff.
> I've changed the package definition to depend on the latest tagged
> source and provided a synopsis & description specific to vte-ng.
> Let me know if you have any other concerns that need to be addressed.
> Thanks!
>
> From 5fa75edd3e03839dc7fc81134a9bd37072409f88 Mon Sep 17 00:00:00 2001
> From: McKinley Olsen <mck.olsen@gmail.com>
> Date: Tue, 31 May 2016 14:28:44 -0600
> Subject: [PATCH] * gnu/packages/gnome.scm (vte-ng): New variable.
First line should be: "gnu: Add vte-ng."

>
> [...]
> +                                  name
> +                                  "/archive/"
> +                                  version
> +                                  ".tar.gz"))
                                     ^^^^ put these into one line.
> +              (file-name (string-append name "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +        #:phases (modify-phases %standard-phases
> +                  (add-after 'unpack 'bootstrap
> +                    (lambda _
> +                      (setenv "NOCONFIGURE" "true")
> +                      (zero? (system* "sh" "autogen.sh")))))))
> +  (synopsis "Enhanced VTE terminal widget")
> +  (description "VTE, with additional functions exposed for keyboard text
> +    selection and URL hints.")))
I expand "VTE" a bit.


Pushed, thanks!