From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: [PATCH 10/13] gnu: v4l-utils: Fix regression caused by update to
	qt 5.7.
Date: Sun, 21 Aug 2016 16:04:37 -0400
Message-ID: <878tvpdh2i.fsf@netris.org>
References: <20160820215957.GA6502@jasmine>
	<20160821140825.13048-1-david@craven.ch>
	<20160821140825.13048-10-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51030)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bbZ0J-0003wt-MW
	for guix-devel@gnu.org; Sun, 21 Aug 2016 16:06:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bbZ0D-0005Ll-M6
	for guix-devel@gnu.org; Sun, 21 Aug 2016 16:05:58 -0400
Received: from world.peace.net ([50.252.239.5]:41649)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bbZ0D-0005Lh-Hw
	for guix-devel@gnu.org; Sun, 21 Aug 2016 16:05:53 -0400
In-Reply-To: <20160821140825.13048-10-david@craven.ch> (David Craven's message
	of "Sun, 21 Aug 2016 16:08:23 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

David Craven <david@craven.ch> writes:

> * gnu/packages/video.scm (v4l-utils)[arguments]: Require gnu++11.
> ---
>  gnu/packages/video.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index bc6415e..28e49b3 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -1396,7 +1396,8 @@ tools, XML authoring components, and an extensible plug-in based API.")
>       '(#:configure-flags
>         (list (string-append "--with-udevdir="
>                              (assoc-ref %outputs "out")
> -                            "/lib/udev"))))
> +                            "/lib/udev")
> +              "CXXFLAGS=-std=gnu++11")))

The " should be lined up under the "(", so that last line should be
moved one column to the left.

Also, although I neglected to mention it, in general when the change
made is simple enough to describe in the summary line, better to do
that, so instead of writing "Fix regression caused by update to qt 5.7",
please write "Require gnu++11.".

Otherwise looks good to me.

     Thanks,
       Mark