From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: [PATCH 42/42] gnu: Add darcs. Date: Wed, 21 Sep 2016 08:27:47 +0000 Message-ID: <878tulfyik.fsf@we.make.ritual.n0.is> References: <20160918161022.26135-1-ng0@we.make.ritual.n0.is> <20160918161022.26135-42-ng0@we.make.ritual.n0.is> <20160921014449.GA18022@jasmine> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmcsu-00070B-6H for guix-devel@gnu.org; Wed, 21 Sep 2016 04:28:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmcsp-0006yx-5H for guix-devel@gnu.org; Wed, 21 Sep 2016 04:28:03 -0400 Received: from aibo.runbox.com ([91.220.196.211]:56173) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmcso-0006yW-UM for guix-devel@gnu.org; Wed, 21 Sep 2016 04:27:59 -0400 In-Reply-To: <20160921014449.GA18022@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org Leo Famulari writes: > On Sun, Sep 18, 2016 at 04:10:22PM +0000, ng0 wrote: >> * gnu/packages/version-control.scm (darcs): New variable. > >> +;; Darcs has no https support: http://irclog.perlgeek.de/darcs/2016-09-17 >> +;; http://darcs.net/manual/Configuring_darcs.html#SECTION00440070000000000000 >> +;; and results of search engines will show that if the protocol is http, https >> +;; is never mentioned. >> +(define-public darcs >> + (package >> + (name "darcs") >> + (version "2.12.4") >> + (source (origin >> + (method url-fetch) >> + (uri (string-append "https://hackage.haskell.org/package/darcs/" >> + "darcs-" version ".tar.gz")) >> + (sha256 >> + (base32 >> + "0jfwiwl5k8wspciq1kpmvh5yap4japrf97s9pvhcybxxhaj3ds28")))) >> + (build-system haskell-build-system) >> + (arguments >> + `(#:configure-flags '("-fpkgconfig" "-fcurl" "-flibiconv" "-fthreaded" >> + "-fnetwork-uri" "-fhttp" "--flag=executable" >> + "--flag=library") >> + #:tests? #f)) ; 20 failing shell tests out of over 400 > > When the test suite fails, it provides a path to the log of the test > suite. I built with --keep-failed to inspect the log, but the file does > not exist. > > Since the test suite is not passing, and there is no log of the tests, > it's hard to decide what to do :) Strange. Can you add a comment for this in the package, so we can fix it eventually? > Does this darcs package work for your use case? Does anyone have advice? > Additionally: Should the complete commented inputs go? They are parts of base of ghc, but then again they display what ghc needs. So far I was able to "darcs get http://pijul.org", I have not signed up at a darcs hosting to push, I thought someone will report a bug when a feature of darcs is broken. My use case worked. For all the other packages: The changes are okay for me. For @ version: The error message Guix throws should be extended. I am doing "-" versions, but I've also seen "@" versions in the code and was confused by the message guix gave me so I switched them to @. Thanks for reviewing this huge bundle! -- ng0