Re: [PATCH] tests: Don't check file-systems in container tests.

[Marius Bakke <mbakke@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1648 bytes --]

Ludovic Courtès <ludo@gnu.org> writes:

> Hi,
>
> Andy Patterson <ajpatter@uwaterloo.ca> skribis:
>
>> The containers test was hanging for me, and this patch fixed the
>> problem.
>
> [...]
>
>> From 945ad44acf489b7f3a398d4ab739ec2b48477502 Mon Sep 17 00:00:00 2001
>> From: Andy Patterson <ajpatter@uwaterloo.ca>
>> Date: Sat, 12 Nov 2016 22:10:01 -0500
>> Subject: [PATCH] tests: Don't check file-systems in container tests.
>>
>> * tests/containers.scm ("call-with-container, mnt namespace"): Don't
>> check file-system in 'call-with-container' call.
>> * tests/containers.scm
>> ("call-with-container, mnt namespace, wrong bindmount"): Likewise.
>> ---
>>  tests/containers.scm | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/containers.scm b/tests/containers.scm
>> index ccd122a..745b56b 100644
>> --- a/tests/containers.scm
>> +++ b/tests/containers.scm
>> @@ -84,7 +84,8 @@
>>     (call-with-container (list (file-system
>>                                  (device "none")
>>                                  (mount-point "/testing")
>> -                                (type "tmpfs")))
>> +                                (type "tmpfs")
>> +                                (check? #f)))
>
> Do you know exactly how/why it was hanging?  I imagine
> ‘mount-file-system’ would try to invoke fsck.tmpfs, which doesn’t exist,
> thus we get a REPL, which hangs forever.
>
> I guess the real question is why I didn’t experience it, hmm…

This is failing for me on master, I think the guix development snapshot
needs to be updated to include this fix.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]