[PATCH 0/7] KDE Framework: Tier 4 and porting aids

[PATCH 0/7] KDE Framework: Tier 4 and porting aids

[Hartmut Goebel]

This patch series complets the KDE Frameworks 5: Tier 4 and porting aids.

See https://api.kde.org/frameworks/ for a list of all framework components.

Hartmut Goebel (7):
  gnu: Add KDE frameworkintegration.
  gnu: Add kdelibs4support.
  gnu: Add khtml.
  gnu: Add kjs.
  gnu: Add kjsembed.
  gnu: Add kmediaplayer.
  gnu: Add kross.

 gnu/packages/kde-frameworks.scm | 346 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 346 insertions(+)

-- 
2.7.4

[PATCH 1/7] gnu: Add KDE frameworkintegration.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (frameworkintegration): New variable.
---
 gnu/packages/kde-frameworks.scm | 51 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 9df37ac..0e6b8fb 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2798,3 +2798,54 @@ setUrl, setUserAgent and call.")
 script engines.")
     ;; dual licensed
     (license (list license:gpl2+ license:lgpl2.1+))))
+
+;; Tier 4
+;;
+;; Tier 4 frameworks can be mostly ignored by application programmers; this
+;; tier consists of plugins acting behind the scenes to provide additional
+;; functionality or platform integration to existing frameworks (including
+;; Qt).
+
+(define-public frameworkintegration
+  (package
+    (name "frameworkintegration")
+    (version "5.27.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "mirror://kde/stable/frameworks/"
+                    (version-major+minor version) "/"
+                    name "-" version ".tar.xz"))
+              (sha256
+               (base32
+                "0zpv7wj2006f039wr1gp5bc4md8yq9ig5g3v5mx46sdjip5423p1"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("kconfig" ,kconfig)
+       ("kconfigwidgets" ,kconfigwidgets)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kiconthemes" ,kiconthemes)
+       ("kitemviews" ,kitemviews)
+       ("knotificantions" ,knotifications)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("qtbase" ,qtbase)
+       ("qtx11extras" ,qtx11extras)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'check-setup
+           (lambda _
+             (setenv "HOME" (getcwd))
+             (setenv "CTEST_OUTPUT_ON_FAILURE" "1") ; Enable debug output
+             (setenv "QT_QPA_PLATFORM" "offscreen")
+             #t)))))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "KDE Frameworks 5 workspace and cross-framework integration plugins")
+    (description "Framework Integration is a set of plugins responsible for
+better integration of Qt applications when running on a KDE Plasma
+workspace.")
+    ;; triple licensed
+    (license (list license:gpl2+ license:lgpl2.0 license:lgpl2.0+))))
-- 
2.7.4

[PATCH 2/7] gnu: Add kdelibs4support.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (kdelibs4support): New variable.
---
 gnu/packages/kde-frameworks.scm | 88 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 88 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 0e6b8fb..a537aa4 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -47,6 +47,7 @@
   #:use-module (gnu packages polkit)
   #:use-module (gnu packages python)
   #:use-module (gnu packages qt)
+  #:use-module (gnu packages tls)
   #:use-module (gnu packages version-control)
   #:use-module (gnu packages web)
   #:use-module (gnu packages xml)
@@ -2849,3 +2850,90 @@ better integration of Qt applications when running on a KDE Plasma
 workspace.")
     ;; triple licensed
     (license (list license:gpl2+ license:lgpl2.0 license:lgpl2.0+))))
+
+;; Porting Aids
+;;
+;; Porting Aids frameworks provide code and utilities to ease the transition
+;; from kdelibs 4 to KDE Frameworks 5. Code should aim to port away from this
+;; framework, new projects should avoid using these libraries.
+
+(define-public kdelibs4support
+  (package
+    (name "kdelibs4support")
+    (version "5.27.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://kde/stable/frameworks/"
+             (version-major+minor version) "/portingAids/"
+             name "-" version ".tar.xz"))
+       (sha256
+        (base32 "17b8d5b9w27251k4r5xc17115nc3k1agv7j7gkmdiybjyilj1n91"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("dbus" ,dbus)
+       ("docbook-xml" ,docbook-xml-4.4) ;; optional, but not found!
+       ("extra-cmake-modules" ,extra-cmake-modules)
+       ("perl", perl)
+       ("perl-uri" ,perl-uri)
+       ("pkg-config" ,pkg-config))) ; to find headers of network manager
+    (inputs
+     `(("kcompletion" ,kcompletion)
+       ("kconfig" ,kconfig)
+       ("kconfigwidgets" ,kconfigwidgets)
+       ("kcrash" ,kcrash)
+       ("kdbusaddons" ,kdbusaddons)
+       ("kded" ,kded)
+       ("kdesignerplugin" ,kdesignerplugin)
+       ("kdoctools" ,kdoctools)
+       ("kglobalaccel" ,kglobalaccel)
+       ("kguiaddons" ,kguiaddons)
+       ("ki18n" ,ki18n)
+       ("kiconthemes" ,kiconthemes)
+       ("kio" ,kio)
+       ("knotifications" ,knotifications)
+       ("kparts" ,kparts)
+       ("kservice" ,kservice)
+       ("ktextwidgets" ,ktextwidgets)
+       ("kunitconversion", kunitconversion)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kwindowsystem" ,kwindowsystem)
+       ("kxmlgui" ,kxmlgui)
+       ("libsm", libsm)
+       ("networkmanager-qt", networkmanager-qt)
+       ("openssl", openssl)
+       ("qtbase" ,qtbase)
+       ("qtsvg" ,qtsvg)
+       ("qttools" ,qttools)
+       ("qtx11extras" ,qtx11extras)))
+    (arguments
+     `(#:tests? #f ; FIXME: 6/39 tests fail.
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'cmake-find-docbook
+           (lambda* (#:key inputs #:allow-other-keys)
+             (substitute* "cmake/FindDocBookXML4.cmake"
+               (("^.*xml/docbook/schema/dtd.*$")
+                "xml/dtd/docbook\n"))
+             #t))
+         (add-before 'check 'check-setup
+           (lambda _
+             (setenv "HOME" (getcwd))
+             (setenv "CTEST_OUTPUT_ON_FAILURE" "1") ; Enable debug output
+             (setenv "QT_QPA_PLATFORM" "offscreen")
+             #t)))))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "KDE Frameworks 5 porting aid from KDELibs4")
+    (description "This framework provides code and utilities to ease the
+transition from kdelibs 4 to KDE Frameworks 5.  This includes CMake macros and
+C++ classes whose functionality has been replaced by code in CMake, Qt and
+other frameworks.
+
+Code should aim to port away from this framework eventually.  The API
+documentation of the classes in this framework and the notes at
+http://community.kde.org/Frameworks/Porting_Notes should help with this.")
+    ;; a variety of licenses
+    (license (list license:gpl2 license:gpl2+ license:lgpl2.0 license:lgpl2.0+
+                   license:lgpl2.1+ license:expat license:bsd-2 license:bsd-3
+                   license:public-domain))))
-- 
2.7.4

[PATCH 3/7] gnu: Add khtml.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (khtml): New variable.
---
 gnu/packages/kde-frameworks.scm | 57 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 57 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index a537aa4..07c6716 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -41,6 +41,7 @@
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages gnupg)
+  #:use-module (gnu packages image)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
@@ -2937,3 +2938,59 @@ http://community.kde.org/Frameworks/Porting_Notes should help with this.")
     (license (list license:gpl2 license:gpl2+ license:lgpl2.0 license:lgpl2.0+
                    license:lgpl2.1+ license:expat license:bsd-2 license:bsd-3
                    license:public-domain))))
+
+(define-public khtml
+  (package
+    (name "khtml")
+    (version "5.27.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://kde/stable/frameworks/"
+             (version-major+minor version) "/portingAids/"
+             name "-" version ".tar.xz"))
+       (sha256
+        (base32 "05ssmgk2gr5v1x1lsvyyspvnlknmkxivgx1g210i9ayl08v8v3c0"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("perl", perl)))
+    (inputs
+     `(("giflib" ,giflib)
+       ("karchive" ,karchive)
+       ("kcodecs" ,kcodecs)
+       ("kglobalaccel" ,kglobalaccel)
+       ("ki18n" ,ki18n)
+       ("kiconthemes" ,kiconthemes)
+       ("kio" ,kio)
+       ("kja" ,kjs)
+       ("knotifications" ,knotifications)
+       ("kparts" ,kparts)
+       ("ktextwidgets" ,ktextwidgets)
+       ("kwallet", kwallet)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kwindowsystem" ,kwindowsystem)
+       ("kxmlgui" ,kxmlgui)
+       ("libjpeg", libjpeg)
+       ("libpng", libpng)
+       ("openssl", openssl)
+       ("phonon", phonon)
+       ("qtbase" ,qtbase)
+       ("qtx11extras" ,qtx11extras)
+       ("sonnet" ,sonnet)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'check-setup
+           (lambda _
+             (setenv "CTEST_OUTPUT_ON_FAILURE" "1") ; Enable debug output
+             (setenv "QT_QPA_PLATFORM" "offscreen")
+             #t)))))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "KDE Frameworks 5 HTML widget and component")
+    (description "KHTML is a web rendering engine, based on the KParts
+technology and using KJS for JavaScript support.")
+    ;; a variety of licenses
+    (license (list license:gpl2 license:lgpl2.0 license:lgpl2.1+ license:gpl3+
+                   license:expat license:bsd-2 license:bsd-3))))
-- 
2.7.4

[PATCH 4/7] gnu: Add kjs.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (kjs): New variable.
---
 gnu/packages/kde-frameworks.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 07c6716..928b7ec 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -43,6 +43,7 @@
   #:use-module (gnu packages gnupg)
   #:use-module (gnu packages image)
   #:use-module (gnu packages linux)
+  #:use-module (gnu packages pcre)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages polkit)
@@ -2994,3 +2995,34 @@ technology and using KJS for JavaScript support.")
     ;; a variety of licenses
     (license (list license:gpl2 license:lgpl2.0 license:lgpl2.1+ license:gpl3+
                    license:expat license:bsd-2 license:bsd-3))))
+
+(define-public kjs
+  (package
+    (name "kjs")
+    (version "5.27.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://kde/stable/frameworks/"
+             (version-major+minor version) "/portingAids/"
+             name "-" version ".tar.xz"))
+       (sha256
+        (base32 "18x4az3v4pbg77sxhmrdrfwrc9d9fw7l40m6p18k1khxn86hsp9j"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("kdoctools" ,kdoctools)
+       ("perl" ,perl)))
+    (inputs
+     `(("pcre" ,pcre)
+       ("qtbase" ,qtbase)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "KDE Frameworks 5 support for Javascript scripting in Qt
+applications")
+    (description "Add-on library to Qt which adds JavaScript scripting
+support.")
+    ;; a variety of licenses
+    (license (list license:lgpl2.0+ license:lgpl2.1+
+                   license:bsd-2 license:bsd-3
+                   license:non-copyleft))))
-- 
2.7.4

[PATCH 5/7] gnu: Add kjsembed.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (kjsembed): New variable.
---
 gnu/packages/kde-frameworks.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 928b7ec..109d3f2 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -3026,3 +3026,32 @@ support.")
     (license (list license:lgpl2.0+ license:lgpl2.1+
                    license:bsd-2 license:bsd-3
                    license:non-copyleft))))
+
+(define-public kjsembed
+  (package
+    (name "kjsembed")
+    (version "5.27.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://kde/stable/frameworks/"
+             (version-major+minor version) "/portingAids/"
+             name "-" version ".tar.xz"))
+       (sha256
+        (base32 "1j42v2l41mwn0ms29b94py21dh7kiipkgdnigpbn89v7nkhwlq2b"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("kdoctools" ,kdoctools)))
+    (inputs
+     `(("ki18n" ,ki18n)
+       ("kjs" ,kjs)
+       ("qtbase" ,qtbase)
+       ("qtsvg" ,qtsvg)
+       ("qttools" ,qttools)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "KDE Frameworks 5 embedded Javascript engine for Qt")
+    (description "KJSEmbed provides a method of binding Javascript objects to
+QObjects, so you can script your applications.")
+    (license license:lgpl2.0+)))
-- 
2.7.4

[PATCH 6/7] gnu: Add kmediaplayer.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (kmediaplayer): New variable.
---
 gnu/packages/kde-frameworks.scm | 46 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 109d3f2..c86d82c 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -3055,3 +3055,49 @@ support.")
     (description "KJSEmbed provides a method of binding Javascript objects to
 QObjects, so you can script your applications.")
     (license license:lgpl2.0+)))
+
+(define-public kmediaplayer
+  (package
+    (name "kmediaplayer")
+    (version "5.27.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://kde/stable/frameworks/"
+             (version-major+minor version) "/portingAids/"
+             name "-" version ".tar.xz"))
+       (sha256
+        (base32 "003jvd2lzp70ywhnkpzgalzqkjpy3d9flkl144z2hfdwm011d58x"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("kdoctools" ,kdoctools)))
+    (inputs
+     `(("kcompletion" ,kcompletion)
+       ("kcoreaddons" ,kcoreaddons)
+       ("ki18n" ,ki18n)
+       ("kiconthemes" ,kiconthemes)
+       ("kio" ,kio)
+       ("kparts" ,kparts)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kxmlgui" ,kxmlgui)
+       ("qtbase" ,qtbase)
+       ("qttools" ,qttools)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'check-setup
+           (lambda _
+             (setenv "CTEST_OUTPUT_ON_FAILURE" "1") ; Enable debug output
+             (setenv "QT_QPA_PLATFORM" "offscreen")
+             #t)))))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "KDE Frameworks 5 plugin interface for media player features")
+    (description "KMediaPlayer builds on the KParts framework to provide a
+common interface for KParts that can play media files.
+
+This framework is a porting aid.  It is not recommended for new projects, and
+existing projects that use it are advised to port away from it, and use plain
+KParts instead.")
+    (license license:expat)))
-- 
2.7.4

[PATCH 7/7] gnu: Add kross.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (kross): New variable.
---
 gnu/packages/kde-frameworks.scm | 43 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index c86d82c..88824e2 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -3101,3 +3101,46 @@ This framework is a porting aid.  It is not recommended for new projects, and
 existing projects that use it are advised to port away from it, and use plain
 KParts instead.")
     (license license:expat)))
+
+(define-public kross
+  (package
+    (name "kross")
+    (version "5.27.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://kde/stable/frameworks/"
+             (version-major+minor version) "/portingAids/"
+             name "-" version ".tar.xz"))
+       (sha256
+        (base32 "13karf890afk3dplxgsjx48vjz1ka12pgsi8qw369xbff5nqy2vj"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("kdoctools" ,kdoctools)))
+    (inputs
+     `(("kcompletion" ,kcompletion)
+       ("kcoreaddons" ,kcoreaddons)
+       ("ki18n" ,ki18n)
+       ("kiconthemes" ,kiconthemes)
+       ("kparts" ,kparts)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kxmlgui" ,kxmlgui)
+       ("qtbase" ,qtbase)
+       ("qtscript" ,qtscript)
+       ("qttools" ,qttools)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "KDE Frameworks 5 solution for application scripting")
+    (description "Kross is a scripting bridge for the KDE Development Platform
+used to embed scripting functionality into an application.  It supports
+QtScript as a scripting interpreter backend.
+
+Kross provides an abstract API to provide scripting functionality in a
+interpreter-independent way.  The application that uses Kross should not need
+to know anything about the scripting language being used.  The core of Kross
+provides the framework to deal transparently with interpreter-backends and
+offers abstract functionality to deal with scripts.")
+    ;; a variety of licenses
+    (license (list license:lgpl2.0 license:lgpl2.0+ license:lgpl2.1+
+                   license:gpl3))))
-- 
2.7.4

Re: [PATCH 1/7] gnu: Add KDE frameworkintegration.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 2859 bytes --]

Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> * gnu/packages/kde-frameworks.scm (frameworkintegration): New variable.
> ---
>  gnu/packages/kde-frameworks.scm | 51 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 51 insertions(+)
>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index 9df37ac..0e6b8fb 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -2798,3 +2798,54 @@ setUrl, setUserAgent and call.")
>  script engines.")
>      ;; dual licensed
>      (license (list license:gpl2+ license:lgpl2.1+))))
> +
> +;; Tier 4
> +;;
> +;; Tier 4 frameworks can be mostly ignored by application programmers; this
> +;; tier consists of plugins acting behind the scenes to provide additional
> +;; functionality or platform integration to existing frameworks (including
> +;; Qt).
> +
> +(define-public frameworkintegration
> +  (package
> +    (name "frameworkintegration")
> +    (version "5.27.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "mirror://kde/stable/frameworks/"
> +                    (version-major+minor version) "/"
> +                    name "-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "0zpv7wj2006f039wr1gp5bc4md8yq9ig5g3v5mx46sdjip5423p1"))))
> +    (build-system cmake-build-system)
> +    (native-inputs
> +     `(("extra-cmake-modules" ,extra-cmake-modules)
> +       ("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("kconfig" ,kconfig)
> +       ("kconfigwidgets" ,kconfigwidgets)
> +       ("kcoreaddons" ,kcoreaddons)
> +       ("kiconthemes" ,kiconthemes)
> +       ("kitemviews" ,kitemviews)
> +       ("knotificantions" ,knotifications)
> +       ("kwidgetsaddons" ,kwidgetsaddons)
> +       ("qtbase" ,qtbase)
> +       ("qtx11extras" ,qtx11extras)))
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'check 'check-setup
> +           (lambda _
> +             (setenv "HOME" (getcwd))
> +             (setenv "CTEST_OUTPUT_ON_FAILURE" "1") ; Enable debug output
> +             (setenv "QT_QPA_PLATFORM" "offscreen")

Could you add a comment explaining what this variable does?

> +             #t)))))
> +    (home-page "https://community.kde.org/Frameworks")
> +    (synopsis "KDE Frameworks 5 workspace and cross-framework integration plugins")
> +    (description "Framework Integration is a set of plugins responsible for
> +better integration of Qt applications when running on a KDE Plasma
> +workspace.")
> +    ;; triple licensed
> +    (license (list license:gpl2+ license:lgpl2.0 license:lgpl2.0+))))

Please clarify. Is it all of them, or either? Or is it mostly gpl2+, but
some files are covered by the other two?

Otherwise LGTM!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]

Re: [PATCH 2/7] gnu: Add kdelibs4support.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 5373 bytes --]

Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> * gnu/packages/kde-frameworks.scm (kdelibs4support): New variable.
> ---
>  gnu/packages/kde-frameworks.scm | 88 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 88 insertions(+)
>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index 0e6b8fb..a537aa4 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -47,6 +47,7 @@
>    #:use-module (gnu packages polkit)
>    #:use-module (gnu packages python)
>    #:use-module (gnu packages qt)
> +  #:use-module (gnu packages tls)
>    #:use-module (gnu packages version-control)
>    #:use-module (gnu packages web)
>    #:use-module (gnu packages xml)
> @@ -2849,3 +2850,90 @@ better integration of Qt applications when running on a KDE Plasma
>  workspace.")
>      ;; triple licensed
>      (license (list license:gpl2+ license:lgpl2.0 license:lgpl2.0+))))
> +
> +;; Porting Aids
> +;;
> +;; Porting Aids frameworks provide code and utilities to ease the transition
> +;; from kdelibs 4 to KDE Frameworks 5. Code should aim to port away from this
> +;; framework, new projects should avoid using these libraries.
> +
> +(define-public kdelibs4support
> +  (package
> +    (name "kdelibs4support")
> +    (version "5.27.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "mirror://kde/stable/frameworks/"
> +             (version-major+minor version) "/portingAids/"
> +             name "-" version ".tar.xz"))
> +       (sha256
> +        (base32 "17b8d5b9w27251k4r5xc17115nc3k1agv7j7gkmdiybjyilj1n91"))))
> +    (build-system cmake-build-system)
> +    (native-inputs
> +     `(("dbus" ,dbus)
> +       ("docbook-xml" ,docbook-xml-4.4) ;; optional, but not found!

Do you mean it's not found even when present? Perhaps just comment it
out, with a "TODO" or "XXX" explaining what this would add, but the
build system needs some changes to pick it up correctly.

> +       ("extra-cmake-modules" ,extra-cmake-modules)
> +       ("perl", perl)
> +       ("perl-uri" ,perl-uri)
> +       ("pkg-config" ,pkg-config))) ; to find headers of network manager

I think most packagers knows what pkg-config is for, so the explanation
seems unnecessary. Are you sure it's only used for network-manager? I
feel bad for complaining about *too many* comments however :)

> +    (inputs
> +     `(("kcompletion" ,kcompletion)
> +       ("kconfig" ,kconfig)
> +       ("kconfigwidgets" ,kconfigwidgets)
> +       ("kcrash" ,kcrash)
> +       ("kdbusaddons" ,kdbusaddons)
> +       ("kded" ,kded)
> +       ("kdesignerplugin" ,kdesignerplugin)
> +       ("kdoctools" ,kdoctools)
> +       ("kglobalaccel" ,kglobalaccel)
> +       ("kguiaddons" ,kguiaddons)
> +       ("ki18n" ,ki18n)
> +       ("kiconthemes" ,kiconthemes)
> +       ("kio" ,kio)
> +       ("knotifications" ,knotifications)
> +       ("kparts" ,kparts)
> +       ("kservice" ,kservice)
> +       ("ktextwidgets" ,ktextwidgets)
> +       ("kunitconversion", kunitconversion)
> +       ("kwidgetsaddons" ,kwidgetsaddons)
> +       ("kwindowsystem" ,kwindowsystem)
> +       ("kxmlgui" ,kxmlgui)
> +       ("libsm", libsm)
> +       ("networkmanager-qt", networkmanager-qt)
> +       ("openssl", openssl)
> +       ("qtbase" ,qtbase)
> +       ("qtsvg" ,qtsvg)
> +       ("qttools" ,qttools)
> +       ("qtx11extras" ,qtx11extras)))
> +    (arguments
> +     `(#:tests? #f ; FIXME: 6/39 tests fail.
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'cmake-find-docbook
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (substitute* "cmake/FindDocBookXML4.cmake"
> +               (("^.*xml/docbook/schema/dtd.*$")
> +                "xml/dtd/docbook\n"))
> +             #t))

Is this related to the docbook-xml comment in native-inputs? Does this
make it work? I would prefer to have the comment here in that case. E.g.
"This is necessary to find schemas from docbook-xml" or similar.

> +         (add-before 'check 'check-setup
> +           (lambda _
> +             (setenv "HOME" (getcwd))
> +             (setenv "CTEST_OUTPUT_ON_FAILURE" "1") ; Enable debug output
> +             (setenv "QT_QPA_PLATFORM" "offscreen")

Is this variable common in the various KDE build phases? If it's
explained somewhere else, it's probably not necessary to add the same
comment (as I requested in the previous patch) to all of them.

Otherwise LGTM!

> +             #t)))))
> +    (home-page "https://community.kde.org/Frameworks")
> +    (synopsis "KDE Frameworks 5 porting aid from KDELibs4")
> +    (description "This framework provides code and utilities to ease the
> +transition from kdelibs 4 to KDE Frameworks 5.  This includes CMake macros and
> +C++ classes whose functionality has been replaced by code in CMake, Qt and
> +other frameworks.
> +
> +Code should aim to port away from this framework eventually.  The API
> +documentation of the classes in this framework and the notes at
> +http://community.kde.org/Frameworks/Porting_Notes should help with this.")
> +    ;; a variety of licenses
> +    (license (list license:gpl2 license:gpl2+ license:lgpl2.0 license:lgpl2.0+
> +                   license:lgpl2.1+ license:expat license:bsd-2 license:bsd-3
> +                   license:public-domain))))

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]

Re: [PATCH 3/7] gnu: Add khtml.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 3203 bytes --]

Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> * gnu/packages/kde-frameworks.scm (khtml): New variable.
> ---
>  gnu/packages/kde-frameworks.scm | 57 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 57 insertions(+)

LGTM!

>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index a537aa4..07c6716 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -41,6 +41,7 @@
>    #:use-module (gnu packages glib)
>    #:use-module (gnu packages gnome)
>    #:use-module (gnu packages gnupg)
> +  #:use-module (gnu packages image)
>    #:use-module (gnu packages linux)
>    #:use-module (gnu packages perl)
>    #:use-module (gnu packages pkg-config)
> @@ -2937,3 +2938,59 @@ http://community.kde.org/Frameworks/Porting_Notes should help with this.")
>      (license (list license:gpl2 license:gpl2+ license:lgpl2.0 license:lgpl2.0+
>                     license:lgpl2.1+ license:expat license:bsd-2 license:bsd-3
>                     license:public-domain))))
> +
> +(define-public khtml
> +  (package
> +    (name "khtml")
> +    (version "5.27.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "mirror://kde/stable/frameworks/"
> +             (version-major+minor version) "/portingAids/"
> +             name "-" version ".tar.xz"))
> +       (sha256
> +        (base32 "05ssmgk2gr5v1x1lsvyyspvnlknmkxivgx1g210i9ayl08v8v3c0"))))
> +    (build-system cmake-build-system)
> +    (native-inputs
> +     `(("extra-cmake-modules" ,extra-cmake-modules)
> +       ("perl", perl)))
> +    (inputs
> +     `(("giflib" ,giflib)
> +       ("karchive" ,karchive)
> +       ("kcodecs" ,kcodecs)
> +       ("kglobalaccel" ,kglobalaccel)
> +       ("ki18n" ,ki18n)
> +       ("kiconthemes" ,kiconthemes)
> +       ("kio" ,kio)
> +       ("kja" ,kjs)
> +       ("knotifications" ,knotifications)
> +       ("kparts" ,kparts)
> +       ("ktextwidgets" ,ktextwidgets)
> +       ("kwallet", kwallet)
> +       ("kwidgetsaddons" ,kwidgetsaddons)
> +       ("kwindowsystem" ,kwindowsystem)
> +       ("kxmlgui" ,kxmlgui)
> +       ("libjpeg", libjpeg)
> +       ("libpng", libpng)
> +       ("openssl", openssl)
> +       ("phonon", phonon)
> +       ("qtbase" ,qtbase)
> +       ("qtx11extras" ,qtx11extras)
> +       ("sonnet" ,sonnet)))
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'check 'check-setup
> +           (lambda _
> +             (setenv "CTEST_OUTPUT_ON_FAILURE" "1") ; Enable debug output
> +             (setenv "QT_QPA_PLATFORM" "offscreen")
> +             #t)))))
> +    (home-page "https://community.kde.org/Frameworks")
> +    (synopsis "KDE Frameworks 5 HTML widget and component")
> +    (description "KHTML is a web rendering engine, based on the KParts
> +technology and using KJS for JavaScript support.")
> +    ;; a variety of licenses
> +    (license (list license:gpl2 license:lgpl2.0 license:lgpl2.1+ license:gpl3+
> +                   license:expat license:bsd-2 license:bsd-3))))
> -- 
> 2.7.4

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]

Re: [PATCH 4/7] gnu: Add kjs.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 2274 bytes --]

Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> * gnu/packages/kde-frameworks.scm (kjs): New variable.
> ---
>  gnu/packages/kde-frameworks.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index 07c6716..928b7ec 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -43,6 +43,7 @@
>    #:use-module (gnu packages gnupg)
>    #:use-module (gnu packages image)
>    #:use-module (gnu packages linux)
> +  #:use-module (gnu packages pcre)
>    #:use-module (gnu packages perl)
>    #:use-module (gnu packages pkg-config)
>    #:use-module (gnu packages polkit)
> @@ -2994,3 +2995,34 @@ technology and using KJS for JavaScript support.")
>      ;; a variety of licenses
>      (license (list license:gpl2 license:lgpl2.0 license:lgpl2.1+ license:gpl3+
>                     license:expat license:bsd-2 license:bsd-3))))
> +
> +(define-public kjs
> +  (package
> +    (name "kjs")
> +    (version "5.27.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "mirror://kde/stable/frameworks/"
> +             (version-major+minor version) "/portingAids/"
> +             name "-" version ".tar.xz"))
> +       (sha256
> +        (base32 "18x4az3v4pbg77sxhmrdrfwrc9d9fw7l40m6p18k1khxn86hsp9j"))))
> +    (build-system cmake-build-system)
> +    (native-inputs
> +     `(("extra-cmake-modules" ,extra-cmake-modules)
> +       ("kdoctools" ,kdoctools)
> +       ("perl" ,perl)))
> +    (inputs
> +     `(("pcre" ,pcre)
> +       ("qtbase" ,qtbase)))
> +    (home-page "https://community.kde.org/Frameworks")
> +    (synopsis "KDE Frameworks 5 support for Javascript scripting in Qt
> +applications")
> +    (description "Add-on library to Qt which adds JavaScript scripting
> +support.")
> +    ;; a variety of licenses
> +    (license (list license:lgpl2.0+ license:lgpl2.1+
> +                   license:bsd-2 license:bsd-3
> +                   license:non-copyleft))))

What is non-copyleft here? Note that "non-copyleft" is a procedure and
can take a file:// style URI (or http etc) to the component in question,
along with an optional comment.

Otherwise LGTM.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]

Re: [PATCH 5/7] gnu: Add kjsembed.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1934 bytes --]

Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> * gnu/packages/kde-frameworks.scm (kjsembed): New variable.
> ---
>  gnu/packages/kde-frameworks.scm | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index 928b7ec..109d3f2 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -3026,3 +3026,32 @@ support.")
>      (license (list license:lgpl2.0+ license:lgpl2.1+
>                     license:bsd-2 license:bsd-3
>                     license:non-copyleft))))
> +
> +(define-public kjsembed
> +  (package
> +    (name "kjsembed")
> +    (version "5.27.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "mirror://kde/stable/frameworks/"
> +             (version-major+minor version) "/portingAids/"
> +             name "-" version ".tar.xz"))
> +       (sha256
> +        (base32 "1j42v2l41mwn0ms29b94py21dh7kiipkgdnigpbn89v7nkhwlq2b"))))
> +    (build-system cmake-build-system)
> +    (native-inputs
> +     `(("extra-cmake-modules" ,extra-cmake-modules)
> +       ("kdoctools" ,kdoctools)))
> +    (inputs
> +     `(("ki18n" ,ki18n)
> +       ("kjs" ,kjs)
> +       ("qtbase" ,qtbase)
> +       ("qtsvg" ,qtsvg)
> +       ("qttools" ,qttools)))

Is qttools referenced in the output? Usually it's only used for building
and should be a native-input; you can check whether it's referenced with
`guix gc -R /gnu/store/...kjsembed-5.27.0`.

The rest LGTM.

> +    (home-page "https://community.kde.org/Frameworks")
> +    (synopsis "KDE Frameworks 5 embedded Javascript engine for Qt")
> +    (description "KJSEmbed provides a method of binding Javascript objects to
> +QObjects, so you can script your applications.")
> +    (license license:lgpl2.0+)))
> -- 
> 2.7.4

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]

Re: [PATCH 6/7] gnu: Add kmediaplayer.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 2520 bytes --]

Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> * gnu/packages/kde-frameworks.scm (kmediaplayer): New variable.
> ---
>  gnu/packages/kde-frameworks.scm | 46 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 46 insertions(+)

Same question about qttools, otherwise LGTM.

>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index 109d3f2..c86d82c 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -3055,3 +3055,49 @@ support.")
>      (description "KJSEmbed provides a method of binding Javascript objects to
>  QObjects, so you can script your applications.")
>      (license license:lgpl2.0+)))
> +
> +(define-public kmediaplayer
> +  (package
> +    (name "kmediaplayer")
> +    (version "5.27.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "mirror://kde/stable/frameworks/"
> +             (version-major+minor version) "/portingAids/"
> +             name "-" version ".tar.xz"))
> +       (sha256
> +        (base32 "003jvd2lzp70ywhnkpzgalzqkjpy3d9flkl144z2hfdwm011d58x"))))
> +    (build-system cmake-build-system)
> +    (native-inputs
> +     `(("extra-cmake-modules" ,extra-cmake-modules)
> +       ("kdoctools" ,kdoctools)))
> +    (inputs
> +     `(("kcompletion" ,kcompletion)
> +       ("kcoreaddons" ,kcoreaddons)
> +       ("ki18n" ,ki18n)
> +       ("kiconthemes" ,kiconthemes)
> +       ("kio" ,kio)
> +       ("kparts" ,kparts)
> +       ("kwidgetsaddons" ,kwidgetsaddons)
> +       ("kxmlgui" ,kxmlgui)
> +       ("qtbase" ,qtbase)
> +       ("qttools" ,qttools)))
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'check 'check-setup
> +           (lambda _
> +             (setenv "CTEST_OUTPUT_ON_FAILURE" "1") ; Enable debug output
> +             (setenv "QT_QPA_PLATFORM" "offscreen")
> +             #t)))))
> +    (home-page "https://community.kde.org/Frameworks")
> +    (synopsis "KDE Frameworks 5 plugin interface for media player features")
> +    (description "KMediaPlayer builds on the KParts framework to provide a
> +common interface for KParts that can play media files.
> +
> +This framework is a porting aid.  It is not recommended for new projects, and
> +existing projects that use it are advised to port away from it, and use plain
> +KParts instead.")
> +    (license license:expat)))
> -- 
> 2.7.4

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]

Re: [PATCH 7/7] gnu: Add kross.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 2708 bytes --]

Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> * gnu/packages/kde-frameworks.scm (kross): New variable.
> ---
>  gnu/packages/kde-frameworks.scm | 43 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index c86d82c..88824e2 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -3101,3 +3101,46 @@ This framework is a porting aid.  It is not recommended for new projects, and
>  existing projects that use it are advised to port away from it, and use plain
>  KParts instead.")
>      (license license:expat)))
> +
> +(define-public kross
> +  (package
> +    (name "kross")
> +    (version "5.27.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "mirror://kde/stable/frameworks/"
> +             (version-major+minor version) "/portingAids/"
> +             name "-" version ".tar.xz"))
> +       (sha256
> +        (base32 "13karf890afk3dplxgsjx48vjz1ka12pgsi8qw369xbff5nqy2vj"))))
> +    (build-system cmake-build-system)
> +    (native-inputs
> +     `(("extra-cmake-modules" ,extra-cmake-modules)
> +       ("kdoctools" ,kdoctools)))
> +    (inputs
> +     `(("kcompletion" ,kcompletion)
> +       ("kcoreaddons" ,kcoreaddons)
> +       ("ki18n" ,ki18n)
> +       ("kiconthemes" ,kiconthemes)
> +       ("kparts" ,kparts)
> +       ("kwidgetsaddons" ,kwidgetsaddons)
> +       ("kxmlgui" ,kxmlgui)
> +       ("qtbase" ,qtbase)
> +       ("qtscript" ,qtscript)
> +       ("qttools" ,qttools)))
> +    (home-page "https://community.kde.org/Frameworks")
> +    (synopsis "KDE Frameworks 5 solution for application scripting")
> +    (description "Kross is a scripting bridge for the KDE Development Platform
> +used to embed scripting functionality into an application.  It supports
> +QtScript as a scripting interpreter backend.
> +
> +Kross provides an abstract API to provide scripting functionality in a
> +interpreter-independent way.  The application that uses Kross should not need
> +to know anything about the scripting language being used.  The core of Kross
> +provides the framework to deal transparently with interpreter-backends and
> +offers abstract functionality to deal with scripts.")
> +    ;; a variety of licenses
> +    (license (list license:lgpl2.0 license:lgpl2.0+ license:lgpl2.1+
> +                   license:gpl3))))

Are you sure it's GPL3, and not GPL3+? If the file headers says GPL3
only it's fine, otherwise I think we default to GPL+.

Otherwise LGTM, assuming you've checked whether qttools is referenced :)

Great to see good KDE support in Guix!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]

Re: [PATCH 1/7] gnu: Add KDE frameworkintegration.

[Hartmut Goebel]

[-- Attachment #1.1: Type: text/plain, Size: 654 bytes --]

Am 21.11.2016 um 18:25 schrieb Marius Bakke:
>> > +    (license (list license:gpl2+ license:lgpl2.0 license:lgpl2.0+))))
> Please clarify. Is it all of them, or either? Or is it mostly gpl2+, but
> some files are covered by the other two?

Thansk for reviewing that quick.

The list of licenses is taken from Debian, which has a detailed lists of
all the licenses used in each package. And KDE often has a *fast* number
of different licenses in one package.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [PATCH 1/7] gnu: Add KDE frameworkintegration.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]

Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> Am 21.11.2016 um 18:25 schrieb Marius Bakke:
>>> > +    (license (list license:gpl2+ license:lgpl2.0 license:lgpl2.0+))))
>> Please clarify. Is it all of them, or either? Or is it mostly gpl2+, but
>> some files are covered by the other two?
>
> Thansk for reviewing that quick.
>
> The list of licenses is taken from Debian, which has a detailed lists of
> all the licenses used in each package. And KDE often has a *fast* number
> of different licenses in one package.

Thanks. Here is the Debian copyright file for this package:

http://metadata.ftp-master.debian.org/changelogs/main/f/frameworkintegration/frameworkintegration_5.28.0-1_copyright

Reading that, it seems this package is mostly gpl2 *OR* gpl3, and that
KDE invokes section 14 [0] of the GPL to decide whether later versions
are allowed.

[0] https://www.gnu.org/licenses/gpl-3.0.html#section14

I wonder if we should seek a statement from KDE allowing the use of
GPL3+ for our packages.

Meanwhile, the way I read it, this package should be '(gpl2 gpl3 lpgl2.0
lgpl2.0+). I would change the comment to something like:

;; This is distributed under either gpl2 or gpl3, but some files are
;; covered by other licenses.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]

Re: [PATCH 1/7] gnu: Add KDE frameworkintegration.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 727 bytes --]

Marius Bakke <mbakke@fastmail.com> writes:

> I wonder if we should seek a statement from KDE allowing the use of
> GPL3+ for our packages.
>
> Meanwhile, the way I read it, this package should be '(gpl2 gpl3 lpgl2.0
> lgpl2.0+). I would change the comment to something like:
>
> ;; This is distributed under either gpl2 or gpl3, but some files are
> ;; covered by other licenses.

Oops, I read the copyright file wrong, I thought the top section was
GPL, but it is in fact LGPL. So the license field should be

'(lgpl2.0 lgpl3.0 lgpl2.0+)

And the comment would be along the lines of "This package is
distributed under either LGPL2 or LGPL3, but some files are explicitly
LGPL2+.".

It would be nice to clarify this with KDE.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]