Re: [PATCH 5/7] gnu: Add kjsembed.

[Marius Bakke <mbakke@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1934 bytes --]

Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> * gnu/packages/kde-frameworks.scm (kjsembed): New variable.
> ---
>  gnu/packages/kde-frameworks.scm | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index 928b7ec..109d3f2 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -3026,3 +3026,32 @@ support.")
>      (license (list license:lgpl2.0+ license:lgpl2.1+
>                     license:bsd-2 license:bsd-3
>                     license:non-copyleft))))
> +
> +(define-public kjsembed
> +  (package
> +    (name "kjsembed")
> +    (version "5.27.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "mirror://kde/stable/frameworks/"
> +             (version-major+minor version) "/portingAids/"
> +             name "-" version ".tar.xz"))
> +       (sha256
> +        (base32 "1j42v2l41mwn0ms29b94py21dh7kiipkgdnigpbn89v7nkhwlq2b"))))
> +    (build-system cmake-build-system)
> +    (native-inputs
> +     `(("extra-cmake-modules" ,extra-cmake-modules)
> +       ("kdoctools" ,kdoctools)))
> +    (inputs
> +     `(("ki18n" ,ki18n)
> +       ("kjs" ,kjs)
> +       ("qtbase" ,qtbase)
> +       ("qtsvg" ,qtsvg)
> +       ("qttools" ,qttools)))

Is qttools referenced in the output? Usually it's only used for building
and should be a native-input; you can check whether it's referenced with
`guix gc -R /gnu/store/...kjsembed-5.27.0`.

The rest LGTM.

> +    (home-page "https://community.kde.org/Frameworks")
> +    (synopsis "KDE Frameworks 5 embedded Javascript engine for Qt")
> +    (description "KJSEmbed provides a method of binding Javascript objects to
> +QObjects, so you can script your applications.")
> +    (license license:lgpl2.0+)))
> -- 
> 2.7.4

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]