Re: [PATCH 4/8] gnu: Add python-dulwich.

[Marius Bakke <mbakke@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1964 bytes --]

Danny Milosavljevic <dannym@scratchpost.org> writes:

> * gnu/packages/python.scm (python-dulwich, python2-dulwich): New variables.
> ---
>  gnu/packages/python.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 9572f3a3c..deb801631 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -12655,3 +12655,28 @@ Features:
>  @item Compiles templates into optimized, yet readable, Python code.
>  @end enumerate")
>      (license (license:x11-style "file://LICENSE"))))
> +
> +(define-public python-dulwich
> +  (package
> +    (name "python-dulwich")
> +    (version "0.16.3")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "dulwich" version))
> +        (sha256
> +          (base32 "0fl47vzfgc3w3rmhn8naii905cjqcp0vc68iyvymxp7567hh6als"))))
> +    (build-system python-build-system)
> +    (propagated-inputs
> +     `(("python-fastimport" ,python-fastimport)))
> +    (native-inputs
> +     `(("python-mock" ,python-mock)
> +       ("python-geventhttpclient" ,python-geventhttpclient)))

Hmm.. Some of these packages come after this package. Please rebase the
series so that fastimport and geventhttpclient come earlier. This helps
when bisecting, for example.

> +    (home-page "https://www.dulwich.io/")
> +    (synopsis "Python git library")
> +    (description "This package provides a Git library for Python.")

This should mention that it is a pure-python implementation. Here is
what I had:

    (synopsis "Git implementation in Python")
    (description
     "Dulwich is an implementation of the Git file formats and protocols
written in pure Python.")

> +    ;; dual-licensed

Is it both, or either? ;-)

I usually write "Can be used with either license.".

> +    (license (list license:asl2.0 license:gpl2+))))
> +
> +(define-public python2-dulwich
> +  (package-with-python2 python-dulwich))

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]