From: Marius Bakke <mbakke@fastmail.com>
To: Leo Famulari <leo@famulari.name>,
26225@debbugs.gnu.org, efraim@flashner.co.il
Subject: bug#26225: [PATCH] guix: Compress and decompress xz archives in parallel.
Date: Sat, 01 Apr 2017 08:52:28 +0200 [thread overview]
Message-ID: <878tnkfwlv.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20170330222235.GB10357@jasmine>
[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]
Leo Famulari <leo@famulari.name> writes:
> Efraim Flashner wrote:
>> * guix/scripts/pack.scm (%compressors): Add flag '-T0' when calling "xz".
>> * guix/utils.scm (decompressed-port, compressed-port,
>> compressed-output-port): Same.
>
>> --- a/guix/utils.scm
>> +++ b/guix/utils.scm
>> @@ -154,7 +155,7 @@ a symbol such as 'xz."
>> (match compression
>> ((or #f 'none) (values input '()))
>> ('bzip2 (filtered-port `(,%bzip2 "-dc") input))
>> - ('xz (filtered-port `(,%xz "-dc") input))
>> + ('xz (filtered-port `(,%xz "-dc -T0") input))
>> ('gzip (filtered-port `(,%gzip "-dc") input))
>> (else (error "unsupported compression scheme" compression))))
>
> Parallel decompression isn't implemented yet, but the extra '-T0' option
> doesn't seem to break anything.
>
> The changes LGTM.
>
> I sent a companion patch to <https://bugs.gnu.org/26316> that enables
> threaded compression when building source tarballs.
Is (parallel-job-count) accessible here? It would be nice to respect it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2017-04-01 6:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1cr0d6-0004an-8g@eggs.gnu.org>
[not found] ` <5vvaqyii1c.fsf@fencepost.gnu.org>
2017-03-30 22:22 ` bug#26225: [PATCH] guix: Compress and decompress xz archives in parallel Leo Famulari
2017-03-31 17:56 ` Kei Kebreau
2017-03-31 23:01 ` Leo Famulari
2017-04-01 6:52 ` Marius Bakke [this message]
2017-04-02 21:21 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tnkfwlv.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me \
--to=mbakke@fastmail.com \
--cc=26225@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.