From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7zBl-0002Sw-LH for guix-patches@gnu.org; Tue, 09 May 2017 03:04:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d7zBi-0007lH-Gg for guix-patches@gnu.org; Tue, 09 May 2017 03:04:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:57873) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d7zBi-0007lA-DM for guix-patches@gnu.org; Tue, 09 May 2017 03:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d7zBi-0007Tz-3C for guix-patches@gnu.org; Tue, 09 May 2017 03:04:02 -0400 Subject: bug#26339: [PATCH v2 01/12] system: Pass to grub. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20170417090148.13791-1-m.othacehe@gmail.com> <20170417090148.13791-2-m.othacehe@gmail.com> <87zienofiy.fsf@gnu.org> <20170508155109.19fa060d@scratchpost.org> <874lwvku5q.fsf@gnu.org> <20170508220415.0a18be95@scratchpost.org> Date: Tue, 09 May 2017 09:03:00 +0200 In-Reply-To: <20170508220415.0a18be95@scratchpost.org> (Danny Milosavljevic's message of "Mon, 8 May 2017 22:04:15 +0200") Message-ID: <878tm6bjh7.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Danny Milosavljevic Cc: 26339@debbugs.gnu.org Hi, Danny Milosavljevic skribis: > On Mon, 08 May 2017 21:47:29 +0200 > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > >> This does not remove the circular dependency, it just expresses it >> differently, so I don=E2=80=99t think it will help. Using >>=20 >> (module-ref (resolve-interface '(gnu system grub)) >> 'grub-configuration-file) >>=20 >> would have achieved the effect you wanted. > > Hmm.... I've tested the @@-version locally by removing all the .go files = and then doing guix system reconfigure ... which took ages every time. And= it worked just fine, no errors, no warnings, nothing. Did I test it wrong? No apparently it worked on Hydra (but as I wrote before, the way build-aux/compile-all.scm builds things doesn=E2=80=99t catch macro-used-before-defined errors, so testing locally doesn=E2=80=99t help m= uch). I was concerned that @@ would effectively cause the same problem as #:use-module, but apparently that=E2=80=99s fine. >> However, that=E2=80=99s pretty much a band-aid, so we should look for a = way to >> improve this. > > Yes, but as soon as the other bootloader patches are merged the band-aid = would be gone. > > We have multiple choices here,=20 > (1) revert all ~12 commits, or > (2) do the band-aid, leave the commits in and review and merge the remain= der later, or > (3) review and merge all the other bootloader patches now... I think we=E2=80=99re fine with the band-aid for now. ;-) We=E2=80=99ll keep reviewing/merging the rest of the series, which apparent= ly provides a nicer bootloader abstraction. > I don't have a strong preference. If I knew how flaky even simple change= s in these modules are I wouldn't have been in favor of refactoring them at= all... (really, just having u-boot with Grub as payload - and grub-efi as = part of regular grub - would have been much simpler than this, in retrospec= t) There=E2=80=99s some flakiness, but I think the circular dependency in this= case was the consequence of a half-baked abstraction. Fortunately the rest of the patch series appears to address this, so we=E2=80=99re all good! I think it remains easy to refactor GuixSD, especially now that we have system tests. Let=E2=80=99s not throw the baby out with the bath water. ;= -) Thanks, Ludo=E2=80=99.