From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: 02/02: gnu: Add s.
Date: Sun, 04 Jun 2017 20:15:58 -0400
Message-ID: <878tl770ht.fsf@netris.org>
References: <20170604144555.7655.18380@vcs0.savannah.gnu.org>
	<20170604144556.5AFA1206F7@vcs0.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57315)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1dHfgu-0003tn-M8
	for guix-devel@gnu.org; Sun, 04 Jun 2017 20:16:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1dHfgq-00058E-MW
	for guix-devel@gnu.org; Sun, 04 Jun 2017 20:16:16 -0400
Received: from world.peace.net ([50.252.239.5]:54930)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <mhw@netris.org>) id 1dHfgq-00057s-H0
	for guix-devel@gnu.org; Sun, 04 Jun 2017 20:16:12 -0400
In-Reply-To: <20170604144556.5AFA1206F7@vcs0.savannah.gnu.org> (Kei Kebreau's
	message of "Sun, 4 Jun 2017 10:45:56 -0400 (EDT)")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Kei Kebreau <kei@openmailbox.org>
Cc: guix-devel@gnu.org

kei@openmailbox.org (Kei Kebreau) writes:

> kkebreau pushed a commit to branch master
> in repository guix.
>
> commit 0e4591bb696a36bc83f75869dd2711987b17b722
> Author: ng0 <ng0@no-reply.pragmatique.xyz>
> Date:   Tue May 16 22:28:58 2017 +0000
>
>     gnu: Add s.
>     
>     * gnu/packages/shells.scm (s): New variable.
>     
>     Signed-off-by: Kei Kebreau <kei@openmailbox.org>
> ---
>  gnu/packages/shells.scm | 61 +++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 61 insertions(+)
>
> diff --git a/gnu/packages/shells.scm b/gnu/packages/shells.scm
> index 5eeb186..5e04e86 100644
> --- a/gnu/packages/shells.scm
> +++ b/gnu/packages/shells.scm
> @@ -503,6 +503,67 @@ Its features include:
>  @end enumerate\n")
>      (license bsd-2)))
>  
> +(define-public s
> +  (let ((commit "6604341edb3a775ff94415762af3ee9bd86bfb3c")
> +        (revision "1"))
> +    (package
> +      (name "s")
> +      (version (string-append "0.0.0-" revision "." (string-take commit 7)))

I think we should rename this package and variable name to 's-shell' or
something along those lines.  's' is commonly used as a local variable
name.  Single character variable names are in short supply, and I don't
think we should allocate them to packages.

Thoughts?

      Mark