From: Marius Bakke <mbakke@fastmail.com>
To: Oleg Pykhalov <go.wigust@gmail.com>, 28129-done@debbugs.gnu.org
Subject: bug#28129: [PATCH 0/1] gnu: python-internetarchive: Update to 1.7.1.
Date: Mon, 21 Aug 2017 23:45:54 +0200 [thread overview]
Message-ID: <878tic4mst.fsf@fastmail.com> (raw)
In-Reply-To: <877ey2aq5w.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1009 bytes --]
Oleg Pykhalov <go.wigust@gmail.com> writes:
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=27699
>
> Danny Milosavljevic <dannym@scratchpost.org> writes:
>> After I fixed up the test invocation, still 11 tests of 105 fail,
>> apparently mostly because the Requests mock doesn't work. Could you
>> take a look?
>
>> The mocking is done in tests/conftest.py in internetarchive-1.6.0.
>
> 11 failed, whose (maybe) all require internet connections. When Guix
> build a package he has no networking inside chroot, has it?
>
> So, we cannot pass those tests. Could we just disable them selectively
> (not all 105)?
Hmf. It amazes me that pytest still has no "networking?" toggle.
The tests can be disabled selectively on the command line with the "-k"
switch. See 'python-pyopenssl' for an example. In this case it would
be something like "not test_item_with_kwargs and not test_ia and not...".
Would you like to try it? I applied this patch regardless since it's
apparently not a new problem. Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
prev parent reply other threads:[~2017-08-21 21:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 20:35 [bug#28129] [PATCH 0/1] gnu: python-internetarchive: Update to 1.7.1 Oleg Pykhalov
2017-08-17 20:40 ` [bug#28129] [PATCH 1/1] " Oleg Pykhalov
2017-08-21 21:45 ` Marius Bakke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tic4mst.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=28129-done@debbugs.gnu.org \
--cc=go.wigust@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.