From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#28157: =?UTF-8?Q?=E2=80=9Cr-minimal=E2=80=9D?= retains no
	reference to =?UTF-8?Q?=E2=80=9Cwhich=E2=80=9D?=
Date: Tue, 22 Aug 2017 15:40:52 +0200
Message-ID: <878tib4t5n.fsf@gnu.org>
References: <87valiwkt9.fsf@elephly.net> <877exwc7eh.fsf@gnu.org>
	<8760dgvu1a.fsf@elephly.net> <87o9r87xhx.fsf@gnu.org>
	<871so3x3uo.fsf@elephly.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58142)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dk9RY-0006zX-Im
	for bug-guix@gnu.org; Tue, 22 Aug 2017 09:42:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dk9RS-0003c7-Ot
	for bug-guix@gnu.org; Tue, 22 Aug 2017 09:42:08 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:40140)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dk9RS-0003bO-KV
	for bug-guix@gnu.org; Tue, 22 Aug 2017 09:42:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dk9RS-00044c-Eo
	for bug-guix@gnu.org; Tue, 22 Aug 2017 09:42:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.28157.B28157.150340926415588@debbugs.gnu.org>
In-Reply-To: <871so3x3uo.fsf@elephly.net> (Ricardo Wurmus's message of "Tue,
	22 Aug 2017 13:02:23 +0200")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 28157@debbugs.gnu.org

Ricardo Wurmus <rekado@elephly.net> skribis:

> Here=E2=80=99s a patch:

That was fast.  :-)

> From bbacb223cbd6f1ba0ca77eda9d168e325537e3f3 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Tue, 22 Aug 2017 12:59:48 +0200
> Subject: [PATCH] gnu: r-minimal: Do not compress serialized files.
>
> * gnu/packages/statistics.scm (r-minimal)[arguments]: Replace build phase
> "patch-which" with "do-not-compress-serialized-files".
> [propagated-inputs]: Move "which" from here...
> [inputs]: ...to here.

[...]

>         (modify-phases %standard-phases
>           ;; FIXME: see bug #28157.
> -         (add-before 'configure 'patch-which
> +         (add-before 'configure 'do-not-compress-serialized-files
>             (lambda* (#:key inputs #:allow-other-keys)
> -             (substitute* "src/library/base/R/unix/system.unix.R"
> -               (("@WHICH@") "which"))

Shouldn=E2=80=99t we keep the =E2=80=98patch-which=E2=80=99 phase?

> +             (substitute* "src/library/base/makebasedb.R"
> +               (("compress =3D TRUE") "compress =3D FALSE"))

Perhaps move the comment about this bug right above this, so we know why
we don=E2=80=99t compress.  Otherwise LGTM!

Any idea how much extra storage this incurs on disk?

Thanks!

Ludo=E2=80=99.