From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kei Kebreau Subject: Re: 01/01: gnu: totem: Enable parallel build. Date: Mon, 13 Nov 2017 07:49:02 -0500 Message-ID: <878tfaz6m9.fsf@posteo.net> References: <20171109014628.6934.66587@vcs0.savannah.gnu.org> <20171109014630.1CC31201B8@vcs0.savannah.gnu.org> <87mv3qyfvf.fsf@netris.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eEEB4-0004lS-82 for guix-devel@gnu.org; Mon, 13 Nov 2017 07:49:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eEEB1-0006tG-22 for guix-devel@gnu.org; Mon, 13 Nov 2017 07:49:26 -0500 Received: from mout02.posteo.de ([185.67.36.66]:59403) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eEEB0-0006sT-OI for guix-devel@gnu.org; Mon, 13 Nov 2017 07:49:22 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 4A97F20ACA for ; Mon, 13 Nov 2017 13:49:18 +0100 (CET) In-Reply-To: <87mv3qyfvf.fsf@netris.org> (Mark H. Weaver's message of "Sun, 12 Nov 2017 23:14:28 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Mark H Weaver Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mark H Weaver writes: > Hi, > > kkebreau@posteo.net (Kei Kebreau) writes: > >> kkebreau pushed a commit to branch master >> in repository guix. >> >> commit e5f748a6c0c774265f52c7246ee7b80bec6d3522 >> Author: Kei Kebreau >> Date: Wed Nov 8 20:42:20 2017 -0500 >> >> gnu: totem: Enable parallel build. >>=20=20=20=20=20 >> * gnu/packages/gnome.scm (totem)[arguments]: Set #:parallel-build? t= o #t >> implicitly. > > Your commit reverted the preceding commit made to our 'totem' package, > namely: > >> commit a97bfa46cdb782f705204a50a10bca9fa98c56b2 >> Author: Adam Van Ymeren >> Date: Fri Oct 13 12:40:50 2017 -0400 >>=20 >> gnu: totem: Disable parallel build due to http://debbugs.gnu.org/288= 13 >>=20=20=20=20=20 >> Fixes . >>=20=20=20=20=20 >> * gnu/packages/gnome.scm (totem)[arguments]: Add #:parallel-build?. >>=20=20=20=20=20 >> Signed-off-by: Ludovic Court=C3=A8s > > Unsurprisingly, this caused bug #28813 to re-appear. Since reverting > this fix, one of the totem builds failed on Hydra with the same error > message described in : > > https://hydra.gnu.org/build/2352092 > > namely: > > [124/150] Compiling Vala source ../totem-3.26.0/src/plugins/sample-vala/t= otem-sample-vala-plugin.vala. > FAILED: src/plugins/sample-vala/sample-vala@sha/totem-sample-vala-plugin.= c src/plugins/sample-vala/sample-vala.h src/plugins/sample-vala/sample-vala= .vapi=20 > valac -C --pkg libpeas-1.0 --pkg gtk+-3.0 -d src/plugins/sample-vala/samp= le-vala@sha --library=3Dsample-vala -H src/plugins/sample-vala/sample-vala.= h --vapi ../sample-vala.vapi --girdir=3D/tmp/guix-build-totem-3.26.0.drv-0/= build/src --pkg=3DTotem-1.0 ../totem-3.26.0/src/plugins/sample-vala/totem-s= ample-vala-plugin.vala > error: Package `Totem-1.0' not found in specified Vala API directories or= GObject-Introspection GIR directories > Compilation failed: 1 error(s), 0 warning(s) > [125/150] Linking target src/plugins/ontop/libontop.so. > [126/150] Linking target src/totem. > [127/150] Generating Totem-1.0.gir with a custom command. > ninja: build stopped: subcommand failed. > phase `build' failed after 15.8 seconds > builder for `/gnu/store/l6pv9v3kvvbj4dfnmqj2irmqzwa9hw4c-totem-3.26.0.drv= ' failed with exit code 1 > @ build-failed /gnu/store/l6pv9v3kvvbj4dfnmqj2irmqzwa9hw4c-totem-3.26.0.d= rv - 1 builder for `/gnu/store/l6pv9v3kvvbj4dfnmqj2irmqzwa9hw4c-totem-3.26.= 0.drv' failed with exit code 1 > > I'd like to understand what led you to believe that removing this fix > was appropriate. In general, we don't add #:parallel-build? #f without > a good reason. The code even included a comment referencing bug #28813. > I assume that you saw the comment, since you removed it. > > So, what made you think that this fix was no longer needed? Can you > help me understand how this happened? > > Mark I mistakenly thought Totem had been updated since that change and I had built it successfully a few times on my computer. I've reverted this change on master. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAloJlL8ACgkQ5qXuPBlG eg2KTA/7BRNiUod54jFwgUU9u2VTsU/HJeomoY1y61cMmjJCRmsVFu3GFBtFj/LE 3527JWsRNpw9NvEMmRI5tLY5z4Wv3SPl+11PpZs2kwQfU345TTpi83W1MsenqvFX FYe11lMj+vBPW7ozkpfAtWbXr31TU+qRpqEVcI5AX6Gm/r50gbNxj1riuuv5lHwk EInL6rQMnGPb6nVxMJfiDQLDGeJgbhsnJU/iJxzakG9ZoVBXVCgvaNR9/LbwHZXE HdNUWrE+vP8L/EW0LAd+iKw+uzCHXUBLrjtdllR2Pojt0fhE24oaCx8/uwaUWbbQ ycuKNIG7TWtXtB5R+x8Zwz1lcqF9kGI+jldi5YpAJQ9iOS3TcMUfCwf8x8hHE2++ ntu1qeUA5xEA4Yemcr093eixXjIdGd0sYEEHRAPbdjUQIV8TNi7CAZRPybGYmtzB 9tGOksHPQodo/y9CXf2zrQQM8Vr2GrhL2PIKqm3PoJcFSgZZxZ6psd2IkqNJb6De nUgDzC3MmqPjfIUmcjglla5t88BLQuCnR9qMsmX0qq6/FqCbCy+GP0RyLaa9nHTm B6fLr4j15949he/VnlWDauxvEyb1tOhYzx2EVDgSJCVDao4RKmtG1H/UefAui9VC gNpOA212/fneee2howj16FMYcszapYZaEkXUQPvjnzUYKBogoVg= =Y7yQ -----END PGP SIGNATURE----- --=-=-=--