From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35275)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eGiQx-0004it-8K
	for guix-patches@gnu.org; Mon, 20 Nov 2017 04:32:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eGiQs-0002G5-95
	for guix-patches@gnu.org; Mon, 20 Nov 2017 04:32:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:39603)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eGiQs-0002Fu-4Y
	for guix-patches@gnu.org; Mon, 20 Nov 2017 04:32:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eGiQr-0006BB-Rr
	for guix-patches@gnu.org; Mon, 20 Nov 2017 04:32:01 -0500
Subject: [bug#29359] [PATCH 28/31] gnu: Add java-xstream.
Resent-Message-ID: <handler.29359.B29359.151117027423699@debbugs.gnu.org>
References: <handler.29359.B.151111429223890.ack@debbugs.gnu.org>
	<20171119175805.902-1-julien@lepiller.eu>
	<20171119175805.902-28-julien@lepiller.eu>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20171119175805.902-28-julien@lepiller.eu>
Date: Mon, 20 Nov 2017 08:44:50 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Message-ID: <878tf1xukt.fsf@elephly.net>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 29359@debbugs.gnu.org


Hi Julien,

> * gnu/packages/java.scm (java-xstream): New variable.
[=E2=80=A6]

> +
> +(define-public java-xstream
> +  (package
> +    (name "java-xstream")
> +    (version "1.4.9")

1.4.10 has been released on May 23, 2017.  It includes a fix for
CVE-2017-7957.  Could you please update this package definition?

> +    (arguments
> +     `(#:jar-name "xstream.jar"
> +       ;; Tests are not in a java subdirectory as assumed by ant-build-s=
ystem
> +       #:tests? #f

Can=E2=80=99t we point it at the root directory and filter the files with t=
est-exclude?

> +    (synopsis "XML serialization library")
> +    (description "XStream is a simple library to serialize objects to XM=
L and
> +back again.")

Maybe replace =E2=80=9Cobjects=E2=80=9D with =E2=80=9CJava objects=E2=80=9D=
.  The description is a bit
short, but I=E2=80=99ll take it :)

> +    (license license:x11)))

This looks like the bsd-3 license:

    https://x-stream.github.io/license.html

Okay to push with these changes.  Thanks!

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net