From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44504) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eL4ac-0007T9-4G for guix-patches@gnu.org; Sat, 02 Dec 2017 05:00:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eL4aZ-0006nX-1B for guix-patches@gnu.org; Sat, 02 Dec 2017 05:00:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:60547) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eL4aY-0006n7-Sz for guix-patches@gnu.org; Sat, 02 Dec 2017 05:00:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eL4aY-00010E-30 for guix-patches@gnu.org; Sat, 02 Dec 2017 05:00:02 -0500 Subject: [bug#27083] screen-lockers: i3lock-color and i3lock-fancy Resent-Message-ID: From: Chris Marusich References: <871skx9ql3.fsf@gmail.com> <20171117101835.whd5f7lincppxlgy@abyayala> <20171117201705.75ldk4yxnpd7m3qa@abyayala> <20171117205734.63tbjhxqbcw6sis7@abyayala> <20171117210211.vdauzbvhrjubwamt@abyayala> <20171117211901.eor5yjlvj3icgbsd@abyayala> <87374uc3tk.fsf@gmail.com> <20171201092731.aea3sdto6dgsqisk@abyayala> Date: Sat, 02 Dec 2017 01:59:29 -0800 In-Reply-To: <20171201092731.aea3sdto6dgsqisk@abyayala> (ng0@n0.is's message of "Fri, 1 Dec 2017 09:27:31 +0000") Message-ID: <878teltpq6.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: ng0 Cc: 27083@debbugs.gnu.org, admin@doloresportalatin.info --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable ng0 writes: > Hi Chris, > > thanks for your review. I'll have no time to address it before next week, > just a couple of comments. No worries! Whenever you can update it, that's great! We're almost there; I think the next update will probably be the final one. > Chris Marusich transcribed 9.7K bytes: >> >> ... >>=20 >> ng0 writes: >>=20 >> > I've changed my mind. As there's also 'i3lock' (without the -color suf= fix) >> > but we don't package it (yet), it would take away the freedom to >> > decide which i3lock you want to use. >> > The author of i3lock-fancy wantsus to use i3lock-color, but there's >> > also a check and it falls back to the normal i3lock. >> > >> > Therefore I think it must be up to people using i3lock-fancy to >> > install i3lock-color AND i3lock-fancy in their system profile >> > (or just i3lock-color in systemprofile + suid it, and i3lock-fancy >> > in the user profile). >>=20 >> I agree with your assessment. For now, I think that's a fine plan, >> although I dislike the fact that by adding the i3lock-fancy package by >> itself, we will make it possible for someone to naively install just >> that package to their profile, only to find that it doesn't work because >> i3lock itself is not installed in the system as a screen locker program. >> However, I can't think of a better solution at this time, and we're >> already doing something similar for the other screen locker packages. >> For example, if you install xscreensaver into your profile without also >> installing it into the system as a screen locker service, xscreensaver >> won't work because it won't be setuid-root. So I think it's OK. > > We'll continue to have these problems with applications, maybe we should > consider it a bug and find a common description. So far it's limited to > screensavers, but I can't think of a reason why this problem would stay > limited to applications of the screensaver class. I've created an email thread to discuss this in more detail on guix-devel. The subject is: "Installing some packages results in "incomplete deployment"". Please look for it and reply there if you have any other thoughts on that matter. For this patch, though, I think it's fine to ask users to install i3lock-fancy and also add to their operating system declaration a screen locker service that uses i3lock. That's how the existing screen lockers have been packaged. > For this specific application (i3lock-fancy), I could ask meskarune if sh= e'd like to add > an error message if none is place already. At the top of the script > check for the existence of the i3lock binary in the users path (simply > 'i3lock', not (only) total paths). If not found, throw an error and abort > with a message that "you need to install i3lock-color". I think that would be nice. I also think we can add i3lock-fancy to Guix even before she makes those changes. >> > i3lock-color should be removed before commiting this patch, >> > and we should add a note about this to the description. Like: >> > "You will need to install i3lock or one of its variants (like >> > i3lock-color) to make use of i3lock-fancy." >>=20 >> I don't understand: why do we need to remove i3lock-color? > > i3lock-fancy is Bash script. I'm patching in the references it > should keep. The 2 calls of i3lock in there must be just 'i3lock', > this will call the binary with the suid, not for example the one > in the store path of i3lock-color (which never worked). > More correct would be this remark: > i3lock-color should be removed from the inputs before commiting > this patch, and we should add a note about this to the description. I understand now, and I agree. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAloieYEACgkQ3UCaFdgi Rp1ngw//bwykTNgNugorp+542SzVbK9r9DXwJRzHkwBuYFPcvDzyFqTG4zzrlshZ C5BbdO9dtiSFnlAl6uZ44qC6o4UMluM3ghlSedpZ7e+T3t+IcGpbdYWizQKcVFqQ xVWVGXHicxbusfWCLcC25tslDankNpkoomy6QznwratqoWh9q93uDqKw6g9/ngEg I9soChHBcmdfYxAeoPgenmB4ex+H2nNUinZRepjtRdRS0CW0qDDdD4eET4GGHE34 Fn0Cb79hMimxFcS2UIVnYu11b+75w4fKOXwBkzh7B5PepbsCNfbgz3a+1k6H4B/4 p9splEc1/bBuGq4CL8yPgiqUzBGO0qVmFMrUbegTFWxKia0inXTPvyUvKRcmZRdn cd6SZzVeZWfa0An8zBfA+Jng1blSznwNGN3cagtbKo8CjqgpCGcb3xmhKkkj9B7y 7RoPruiEF3faLI8miDFIVoScMUOfkFb6u4hQOcimNwDMXWD1RHWDxxoOKE3ZpudR FQk84heVgGWvjspGSJRXDx2BkQqf+z3hBKuxARG3HU3LnFWNKSlNZe4KAMoCJ+jM sB9qgbektvWA7L6E8LqNp0yTSjuC6aoiE9NqKdma8YracD97j2PIEIM2H5MltrxH 8WIOypqA/+SVBH9IZMEPoAlidlaK0EMPIDRDuEchzJpuKA5gw+Q= =vGJT -----END PGP SIGNATURE----- --=-=-=--