From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45869) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eL4dX-0008Mq-CB for guix-patches@gnu.org; Sat, 02 Dec 2017 05:03:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eL4dU-0003XP-9Q for guix-patches@gnu.org; Sat, 02 Dec 2017 05:03:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:60554) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eL4dU-0003XL-6C for guix-patches@gnu.org; Sat, 02 Dec 2017 05:03:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eL4dS-00015n-7T for guix-patches@gnu.org; Sat, 02 Dec 2017 05:03:03 -0500 Subject: [bug#29480] [PATCH] gnu: Add xautolock. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87zi7786b0.fsf@gnu.org> <87y3mn3jec.fsf@gnu.org> <87indq0xhw.fsf@gnu.org> Date: Sat, 02 Dec 2017 11:02:06 +0100 In-Reply-To: <87indq0xhw.fsf@gnu.org> (Mike Gerwitz's message of "Fri, 01 Dec 2017 19:44:27 -0500") Message-ID: <878tel30td.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Mike Gerwitz Cc: 29480-done@debbugs.gnu.org Hi, Mike Gerwitz skribis: > On Thu, Nov 30, 2017 at 15:56:11 +0100, Ludovic Court=C3=A8s wrote: >> I took the liberty to make the changes below: > > Ah, thanks! > >> diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm >> - (zero? (system* "xmkmf")) >> + (invoke "xmkmf") > > Okay, that makes much more sense. I was wondering if `zero?' had some > special meaning in that context. =E2=80=98zero?=E2=80=99 returns a Boolean and in this case it was ignored. > gnu/packages/xfig.scm:93 uses it in a non-tail position as well. I > looked at the history for the file but it was always like that; > perhaps that should be `invoke' too? I guess we should! I=E2=80=99ve made the change and will push soonish. Thanks, Ludo=E2=80=99.