From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34661)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ej51Y-0008Bj-Q0
	for guix-patches@gnu.org; Tue, 06 Feb 2018 10:19:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ej51S-0007WD-Ql
	for guix-patches@gnu.org; Tue, 06 Feb 2018 10:19:08 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:52530)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1ej51S-0007Vz-ML
	for guix-patches@gnu.org; Tue, 06 Feb 2018 10:19:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ej51S-0000TD-Gp
	for guix-patches@gnu.org; Tue, 06 Feb 2018 10:19:02 -0500
Subject: [bug#30196] [PATCH 1/2] gnu: Add wesnoth-server.
Resent-Message-ID: <handler.30196.B30196.15179302971755@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180121183348.29317-1-arunisaac@systemreboot.net>
	<20180121183713.29457-1-arunisaac@systemreboot.net>
Date: Tue, 06 Feb 2018 16:18:13 +0100
In-Reply-To: <20180121183713.29457-1-arunisaac@systemreboot.net> (Arun Isaac's
	message of "Mon, 22 Jan 2018 00:07:12 +0530")
Message-ID: <878tc66tai.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 30196@debbugs.gnu.org

Hi Arun,

Arun Isaac <arunisaac@systemreboot.net> skribis:

> * gnu/packages/games.scm (wesnoth-server): New variable.


[...]

> +(define-public wesnoth-server
> +  (package
> +    (inherit wesnoth)
> +    (name "wesnoth-server")
> +    (inputs
> +     `(("boost" ,boost)
> +       ("sdl-net" ,sdl-net)))
> +    (arguments
> +     (append
> +      (substitute-keyword-arguments (package-arguments wesnoth)
> +        ((#:configure-flags configure-flags)
> +         `(append ,configure-flags (list "-DENABLE_GAME=3DOFF"))))
> +      `(#:phases
> +        (modify-phases %standard-phases
> +          (add-after 'install 'delete-data
> +            (lambda* (#:key outputs #:allow-other-keys)
> +              (delete-file-recursively (string-append (assoc-ref outputs=
 "out")
> +                                                      "/share/wesnoth"))=
))))))

I suppose this phase is because the game data isn=E2=80=99t actually used b=
y the
server, right?  Perhaps worth mentioning in a comment.

> +    (synopsis "Dedicated Battle for Wesnoth server")

Maybe =E2=80=9CServer for the @emph{Battle for Wesnoth} game=E2=80=9D.

> +    (description "This package contains a dedicated server for The Battl=
e for
> +Wesnoth.")))

Likewise.

OK with these changes, thanks!

Ludo=E2=80=99.