From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54512)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ewWS6-0002dC-VY
	for guix-patches@gnu.org; Thu, 15 Mar 2018 13:14:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ewWS2-0002m4-GA
	for guix-patches@gnu.org; Thu, 15 Mar 2018 13:14:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:55698)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1ewWS2-0002lr-C9
	for guix-patches@gnu.org; Thu, 15 Mar 2018 13:14:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ewWS2-0002yP-2I
	for guix-patches@gnu.org; Thu, 15 Mar 2018 13:14:02 -0400
Subject: [bug#30817] [PATCH] openssh-service: export AcceptEnv option
Resent-Message-ID: <handler.30817.B30817.152113402211394@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <25eef45c-9acd-29ab-d82e-5dbc16909ef4@uni-bremen.de>
Date: Thu, 15 Mar 2018 18:13:37 +0100
In-Reply-To: <25eef45c-9acd-29ab-d82e-5dbc16909ef4@uni-bremen.de> (Martin
	Castillo's message of "Wed, 14 Mar 2018 15:55:14 +0100")
Message-ID: <878tattg72.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Martin Castillo <castilma@uni-bremen.de>
Cc: 30817@debbugs.gnu.org

Hello,

Martin Castillo <castilma@uni-bremen.de> skribis:

> This patch makes AcceptEnv configurable from config.scm.

Nice!

> Questions:
> Is the dash in environment-variables correct?

No, just =E2=80=9Cenvironment variables=E2=80=9D.

> Why are there always two spaces after a period?

It=E2=80=99s inherited from an (old) convention honored by Emacs notably th=
at
mimics English typographic conventions regarding spacing after
end-of-sentence periods.

> Is @option the correct annotation for AcceptEnv?

@option is normally for command-line option, so I=E2=80=99d just use @code.

> From e64e4a908936c5aec0c026324cc08be12edb8ec1 Mon Sep 17 00:00:00 2001
> From: Martin Castillo <castilma@uni-bremen.de>
> Date: Tue, 13 Mar 2018 16:40:55 +0100
> Subject: [PATCH] services: openssh: Add 'AcceptEnv' field.
>
> * gnu/services/ssh.scm (<openssh-configuration>)[AcceptEnv]: New field.
> (openssh-config-file): Honor 'AcceptEnv'.
> * doc/guix.texi (Networking Services): Document it.

Overall the patch LGTM, so the comments below are really nitpicking:

> +@item @code{accept-env} (default: @code{'()})
> +List of strings describing which environment-variables may be exported.
> +
> +Each string gets on its own line.  See the @option{AcceptEnv} option in
> +@code{sshd_config(5)}.

I=E2=80=99d write =E2=80=9C=E2=80=A6 in @code{man sshd_config(5)}.=E2=80=9D

> +@example
> +(service openssh-service-type
> +         (openssh-configuration
> +		  (accept-env '("COLORTERM"))))
> +@end example

Please add a sentence describing the example, even if it seems obvious.

> +  ;; list of strings
> +  (accept-env            openssh-configuration-accept-env
> +                         (default '()))

We usually avoid abbreviations, so that would be =E2=80=9Caccepted-environm=
ent=E2=80=9D
(see <https://gnu.org/software/guix/manual/html_node/Formatting-Code.html>).

Could you send an updated patch?

Thanks,
Ludo=E2=80=99.