From: Carlo Zancanaro <carlo@zancanaro.id.au>
To: 30948@debbugs.gnu.org
Subject: [bug#30948] [PATCH core-updates] guix: Reap finished child processes in build containers.
Date: Tue, 27 Mar 2018 10:39:41 +1100 [thread overview]
Message-ID: <878tae76f6.fsf@zancanaro.id.au> (raw)
In-Reply-To: <87muyvulwt.fsf@zancanaro.id.au>
[-- Attachment #1.1: Type: text/plain, Size: 301 bytes --]
Okay, it turns out my previous patch was very wrong. I tried to
start a build and it broke pretty significantly.
I've attached a new patch that at least starts building. My
computer takes too long to actually build anything, but I'm
slightly more confident that my change won't break everything.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-guix-Reap-finished-child-processes-in-build-containe.patch --]
[-- Type: text/x-patch, Size: 1693 bytes --]
From c57b2fe19865afc21fd1fd9a7cad3286b05a9b22 Mon Sep 17 00:00:00 2001
From: Carlo Zancanaro <carlo@zancanaro.id.au>
Date: Mon, 26 Mar 2018 22:08:26 +1100
Subject: [PATCH] guix: Reap finished child processes in build containers.
* guix/derivations (build-expression->derivation)[prologue]: Handle SIGCHLD
and reap child processes when they finish.
---
guix/derivations.scm | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/guix/derivations.scm b/guix/derivations.scm
index da686e89e..27ab3e420 100644
--- a/guix/derivations.scm
+++ b/guix/derivations.scm
@@ -1201,6 +1201,21 @@ ALLOWED-REFERENCES, DISALLOWED-REFERENCES, LOCAL-BUILD?, and SUBSTITUTABLE?."
(else drv))))))
inputs))
+ ;; The root process in the build container should reap
+ ;; processes that die, so handle SIGCHLD.
+ (use-modules (ice-9 match))
+ (sigaction SIGCHLD
+ (lambda _
+ (let loop ()
+ (match (catch 'system-error
+ (lambda ()
+ (waitpid WAIT_ANY WNOHANG))
+ (lambda args
+ '(0 . -)))
+ ((0 . _) #f)
+ ((pid . _) (loop)))))
+ SA_NOCLDSTOP)
+
,@(if (null? modules)
'()
;; Remove our own settings.
--
2.16.2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-03-26 23:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 11:16 [bug#30948] [PATCH core-updates] guix: Reap finished child processes in build containers Carlo Zancanaro
2018-03-26 23:39 ` Carlo Zancanaro [this message]
2018-03-29 20:07 ` Ludovic Courtès
2018-03-29 21:15 ` Carlo Zancanaro
2018-03-30 8:16 ` Ludovic Courtès
2018-03-30 11:17 ` Carlo Zancanaro
2018-03-30 15:17 ` Ludovic Courtès
2022-11-24 16:40 ` Maxim Cournoyer
2022-11-24 16:44 ` bug#30948: " Maxim Cournoyer
2022-11-26 15:11 ` Ludovic Courtès
2022-11-27 3:00 ` Maxim Cournoyer
2022-11-28 15:04 ` Ludovic Courtès
2022-11-28 20:10 ` Maxim Cournoyer
2022-11-29 2:07 ` Maxim Cournoyer
2023-12-17 20:23 ` bug#30948: [PATCH core-updates] build-system/gnu: Turn PID 1 into an “init”-style process by default Ludovic Courtès
2023-12-17 21:46 ` Maxim Cournoyer
2023-12-18 17:46 ` bug#30948: [PATCH core-updates] guix: Reap finished child processes in build containers Ludovic Courtès
2023-12-30 3:36 ` Maxim Cournoyer
2023-12-19 22:56 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tae76f6.fsf@zancanaro.id.au \
--to=carlo@zancanaro.id.au \
--cc=30948@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.