From: Marius Bakke <mbakke@fastmail.com>
To: "Tomáš Čech" <sleep_walker@gnu.org>, 31121@debbugs.gnu.org
Subject: [bug#31121] [PATCH 3/3] gnu: Add osc.
Date: Wed, 18 Apr 2018 13:21:02 +0200 [thread overview]
Message-ID: <878t9kbw0x.fsf@fastmail.com> (raw)
In-Reply-To: <20180417214042.31132-1-sleep_walker@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2254 bytes --]
Tomáš Čech <sleep_walker@gnu.org> writes:
> * gnu/packages/build-tools.scm (osc): New variable.
[...]
> +(define-public osc
> + (package
> + (name "osc")
^
Indentation off here too.
> + (version "0.162.1")
> + (source
> + (origin
> + (method url-fetch)
^
And here.
> + (uri (string-append "https://github.com/openSUSE/" name
> + "/archive/" version ".tar.gz"))
> + (file-name (string-append name "-" version ".tar.gz"))
> + (sha256
> + (base32 "0b4kpm96ns4smqyfjysbk2p78d36x44xprpna8zz85q1y5xn57aj"))))
> + (build-system python-build-system)
> + (arguments
> + `(#:python ,python-2 ;; Module is python2 only.
^
Only one semicolon for margin comments.
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'install 'fix-filename-and-remove-unused
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((bin (string-append (assoc-ref outputs "out") "/bin/")))
> + ;; Main osc tool is renamed in spec file, not setup.py, let's
> + ;; do that too.
> + (rename-file
> + (string-append bin "osc-wrapper.py")
> + (string-append bin "osc"))
> + ;; Remove unused and broken script.
> + (delete-file (string-append bin "osc_hotshot.py"))
> + #t))))))
> + (inputs
> + `(("python2-m2crypto" ,python2-m2crypto)
> + ("python2-pycurl" ,python2-pycurl)
> + ("python2-urlgrabber" ,python2-urlgrabber)))
> + (home-page "https://github.com/openSUSE/osc")
> + (synopsis "Open Build Service command line tool")
> + (description "@command{osc} is command line interface to Open Build
^^^ ^^^
"is a" "to the"
Other than that LGTM.
> +Service. It allows you to checkout, commit, perform reviews etc. The vast
> +majority of the OBS functionality is available via commands and the rest can
> +be reached via direct API calls.")
> + (license license:gpl2+)))
> --
> 2.16.3
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2018-04-18 11:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 9:24 [bug#31121] [PATCH 1/3] gnu: Add python2-urlgrabber Tomáš Čech
2018-04-10 9:29 ` [bug#31121] [PATCH 2/3] gnu: Add python-m2crypto, python2-m2crypto Tomáš Čech
2018-04-10 9:29 ` [bug#31121] [PATCH 3/3] gnu: Add osc Tomáš Čech
2018-04-16 22:04 ` Marius Bakke
2018-04-17 21:39 ` [bug#31121] [PATCH 2/3] gnu: Add python-m2crypto, python2-m2crypto Tomáš Čech
2018-04-18 11:17 ` Marius Bakke
2018-04-17 21:40 ` [bug#31121] [PATCH 3/3] gnu: Add osc Tomáš Čech
2018-04-18 11:21 ` Marius Bakke [this message]
2018-04-18 12:34 ` Tomáš Čech
2018-04-19 15:41 ` Marius Bakke
2018-04-16 21:54 ` [bug#31121] [PATCH 2/3] gnu: Add python-m2crypto, python2-m2crypto Marius Bakke
2018-04-16 21:36 ` [bug#31121] [PATCH 1/3] gnu: Add python2-urlgrabber Marius Bakke
2018-04-16 21:46 ` Tomáš Čech
2018-04-16 23:13 ` Marius Bakke
2018-04-17 21:38 ` Tomáš Čech
2018-04-18 11:22 ` Marius Bakke
2018-04-21 6:42 ` bug#31121: patchset Tomáš Čech
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878t9kbw0x.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=31121@debbugs.gnu.org \
--cc=sleep_walker@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.