From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36103)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fGhAH-00025v-T6
	for guix-patches@gnu.org; Thu, 10 May 2018 04:43:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fGhAE-0003If-Ly
	for guix-patches@gnu.org; Thu, 10 May 2018 04:43:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:48039)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fGhAE-0003IX-JU
	for guix-patches@gnu.org; Thu, 10 May 2018 04:43:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fGhAE-0002U5-DK
	for guix-patches@gnu.org; Thu, 10 May 2018 04:43:02 -0400
Subject: [bug#31386] [PATCH 1/3] gnu: eigen: Include unsupported features.
Resent-Message-ID: <handler.31386.B31386.15259417489508@debbugs.gnu.org>
References: <idj603y42r9.fsf@bimsb-sys02.mdc-berlin.net>
	<20180508145909.25354-1-ricardo.wurmus@mdc-berlin.de>
	<87vabwv48t.fsf@gnu.org>
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
In-Reply-To: <87vabwv48t.fsf@gnu.org>
Date: Thu, 10 May 2018 10:42:14 +0200
Message-ID: <878t8rgavt.fsf@mdc-berlin.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 31386@debbugs.gnu.org


Ludovic Court=C3=A8s <ludo@gnu.org> writes:

> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
>
>> * gnu/packages/algebra.scm (eigen)[source]: Do not build the tests for
>> unsupported features, but include the files.
>
> I was reluctant about installing those, but IIRC they go to
> $includedir/=E2=80=A6/unsupported, right?  In that case, it=E2=80=99s up =
to users to
> explicitly #include from unsupported/ so it=E2=80=99s probably fine.

That=E2=80=99s correct.

As it turns out, this alone is not sufficient for TensorFlow.  They have
some additional Eigen source files that they bundle with the TensorFlow
sources, which must be present at build time.

--
Ricardo