From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60081)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fMduB-0003Ry-Fz
	for guix-patches@gnu.org; Sat, 26 May 2018 14:27:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fMduA-0005AG-LG
	for guix-patches@gnu.org; Sat, 26 May 2018 14:27:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:41989)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fMduA-0005A5-HT
	for guix-patches@gnu.org; Sat, 26 May 2018 14:27:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fMduA-000164-Bh
	for guix-patches@gnu.org; Sat, 26 May 2018 14:27:02 -0400
Subject: [bug#31520] [PATCH] gnu: u-boot-tools: Enable tests.
Resent-Message-ID: <handler.31520.B31520.15273591904177@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180518191247.18456-1-dannym@scratchpost.org>
Date: Sat, 26 May 2018 20:26:20 +0200
In-Reply-To: <20180518191247.18456-1-dannym@scratchpost.org> (Danny
	Milosavljevic's message of "Fri, 18 May 2018 21:12:47 +0200")
Message-ID: <878t861df7.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 31520@debbugs.gnu.org

Hey Danny,

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> * gnu/packages/bootloaders.scm (dtc)[native-search-paths]: Add PYTHONPATH.
> (u-boot-tools)[native-inputs]: Add openssl, python2-coverage, python2-pyt=
est,
> sdl.
> [arguments]<#:make-flags>: Remove NO_SDL.
> [arguments]<#:test-target>: Change to "tests".
> [arguments]<#:phases>[patch]: New phase.
> [arguments]<#:phases>[check]: Replace and move.

No need to repeat =E2=80=9C[arguments]=E2=80=9D.

> +    (native-search-paths
> +      (list (search-path-specification
> +             (variable "PYTHONPATH")
> +             (files '("/lib/python2.7/site-packages")))))

Why is it needed?  That would need a comment.  :-)  Even better if we
can achieve the same effect without defining this search path.

Also no need for the leading slash in =E2=80=98files=E2=80=99.

> +           (add-after 'install 'check
> +             (lambda* (#:key make-flags test-target #:allow-other-keys)
> +               (apply invoke "make" "mrproper" make-flags)
> +               (setenv "SDL_VIDEODRIVER" "dummy")
> +               (setenv "PAGER" "cat")
> +               (apply invoke "make" test-target make-flags)
> +               (symlink "build-sandbox_spl" "sandbox")
> +               (invoke "test/image/test-imagetools.sh"))))))

Please return #t.

Thanks!

Ludo=E2=80=99.