From: ludo@gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 31520@debbugs.gnu.org
Subject: [bug#31520] [PATCH] gnu: u-boot-tools: Enable tests.
Date: Sat, 26 May 2018 20:26:20 +0200 [thread overview]
Message-ID: <878t861df7.fsf@gnu.org> (raw)
In-Reply-To: <20180518191247.18456-1-dannym@scratchpost.org> (Danny Milosavljevic's message of "Fri, 18 May 2018 21:12:47 +0200")
Hey Danny,
Danny Milosavljevic <dannym@scratchpost.org> skribis:
> * gnu/packages/bootloaders.scm (dtc)[native-search-paths]: Add PYTHONPATH.
> (u-boot-tools)[native-inputs]: Add openssl, python2-coverage, python2-pytest,
> sdl.
> [arguments]<#:make-flags>: Remove NO_SDL.
> [arguments]<#:test-target>: Change to "tests".
> [arguments]<#:phases>[patch]: New phase.
> [arguments]<#:phases>[check]: Replace and move.
No need to repeat “[arguments]”.
> + (native-search-paths
> + (list (search-path-specification
> + (variable "PYTHONPATH")
> + (files '("/lib/python2.7/site-packages")))))
Why is it needed? That would need a comment. :-) Even better if we
can achieve the same effect without defining this search path.
Also no need for the leading slash in ‘files’.
> + (add-after 'install 'check
> + (lambda* (#:key make-flags test-target #:allow-other-keys)
> + (apply invoke "make" "mrproper" make-flags)
> + (setenv "SDL_VIDEODRIVER" "dummy")
> + (setenv "PAGER" "cat")
> + (apply invoke "make" test-target make-flags)
> + (symlink "build-sandbox_spl" "sandbox")
> + (invoke "test/image/test-imagetools.sh"))))))
Please return #t.
Thanks!
Ludo’.
next prev parent reply other threads:[~2018-05-26 18:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 19:12 [bug#31520] [PATCH] gnu: u-boot-tools: Enable tests Danny Milosavljevic
2018-05-26 18:26 ` Ludovic Courtès [this message]
2018-05-26 19:16 ` Danny Milosavljevic
2018-05-27 13:10 ` Ludovic Courtès
2018-05-27 22:05 ` Danny Milosavljevic
2018-05-28 7:57 ` Ludovic Courtès
2018-05-28 21:52 ` bug#31520: " Danny Milosavljevic
2018-05-29 14:33 ` [bug#31520] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878t861df7.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=31520@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.