From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42444) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXYjS-0005MN-6g for guix-patches@gnu.org; Mon, 25 Jun 2018 17:09:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXYjO-0000e8-Vq for guix-patches@gnu.org; Mon, 25 Jun 2018 17:09:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:55697) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fXYjO-0000dD-De for guix-patches@gnu.org; Mon, 25 Jun 2018 17:09:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fXYjO-0007hT-80 for guix-patches@gnu.org; Mon, 25 Jun 2018 17:09:02 -0400 Subject: [bug#31958] [PATCH] gnu: Add python-pyblake2. Resent-Message-ID: From: Vagrant Cascadian In-Reply-To: <874lhqej9d.fsf@fastmail.com> References: <87o9g0ne4s.fsf@aikidev.net> <874lhqej9d.fsf@fastmail.com> Date: Mon, 25 Jun 2018 14:07:43 -0700 Message-ID: <878t72o9r4.fsf@aikidev.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke , 31958@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2018-06-25, Marius Bakke wrote: > Vagrant Cascadian writes: > >> Add new package definition for python-pyblake2, needed to upgrade >> python-trezor to recent versions. > > Thanks! Some comments: > > [...] > >> * gnu/packages/libusb.scm (python-pyblake2): New variable. >> --- >> gnu/packages/python.scm | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) > > There is a mismatch between the commit message and the code here :-) Oops! obvious cut-and-paste error here... > Though I think this is better suited in 'python-crypto.scm'. WDYT? I'll happily defer to someone who knows their way around guix more. :) >> + (home-page "https://github.com/dchest/pyblake2") >> + (synopsis >> + "BLAKE2 hash function extension module") > > Superfluous line break. Will fix. >> + (description >> + "BLAKE2 hash function extension module") > > Can you try to expand on this a little? I can try, sure. >> + (license license:cc0))) > > According to COPYING, this software is actually "octuple-licensed": > > * CC0 Universal 1.0 - http://creativecommons.org/publicdomain/zero/1.0 > * Unlicense =E2=80=94 http://unlicense.org/ > * WTFPL Version 2 - http://www.wtfpl.net/ > * Apache Public License 2.0 - https://www.apache.org/licenses/LICENSE-2.0 > * OpenSSL License - https://www.openssl.org/source/license.html > * MIT License - https://opensource.org/licenses/MIT > * The BSD 3-Clause License - https://opensource.org/licenses/BSD-3-Clause > * ISC License - https://opensource.org/licenses/ISC > > Can you add each of these, along with an explaning comment? And all of those are merely fallback licenses to the author's intention of public domain... and in the files themselves (pyblake2module.c, setup.py), they only reference: http://creativecommons.org/publicdomain/zero/1.0 But if it's more appropriate for guix to list all possible licenses, sure. :) live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEcDardHbDotegGFCHt4uC1IFLkbYFAlsxWZ8ACgkQt4uC1IFL kbarqA//ZJysmLR4nj5BR5LIyindMX38hkVauaKENj6E5BKYlGB7ZYhu+Q8uIjVI cFTqQgVb8leryN219ZkOFRdiwUbOzKEOReZnMpT7cDtaSMkB0HZTqPjh8sAxYfnQ JJ0JvOJxSNm3SfBeS6XrQPA8MrbWrrH+NJsNLRmcD2AK2Hp/vq91jnpAkgZToAgA Eh++53bxo6CkQ2q0ZErMS2xQhyRAsBCdVGuGo6C0sdZ7ToW4yydLXAn5uWFotMLX hq2+yO1vhedn+dF0Si+LP/+JneDZFKBO6TUPZcsdQgj1mgqFjrda0zPniNfFS6Z/ MvK+qWEK2jA0py37tCLjgRir3dDUnL9FhJKq7Aj3tLL8w3ogIKcT/RuRxNMldUSl PzjnI/R5Pg98Dp49oa6jBqA/ZLwNGaHnaZQI+32l4v4WQOmoMU4PM7eCFFYzx/4j 0tyjgRn8fK7tWY+LCT8ThWSKVvBHIB4q++QsWUgNWh8K9JYWM0XjxUbLPzKoJiOa fryrIPBeYRCeVk75rwxqK+9HXqyb+v+KE/hbqt87pNTSlO3RVE35WpOOUuBiSRiS lh4ruvL+Ba1PaICk7M+NvB0MyLbR4hNW6gMRAMHNkrdDm5SG7/WKXcnMOqB5Z0Vt HpvLeuCTDb2CfsRkaNC62lRUeT02mAXnUyrcpIOIgocz95NSmSA= =+ca3 -----END PGP SIGNATURE----- --=-=-=--