From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fk7iX-0004p7-Tc for guix-patches@gnu.org; Mon, 30 Jul 2018 08:56:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fk7iU-0008JY-Pt for guix-patches@gnu.org; Mon, 30 Jul 2018 08:56:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:57679) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fk7iU-0008JG-Jk for guix-patches@gnu.org; Mon, 30 Jul 2018 08:56:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fk7iU-0000U8-9t for guix-patches@gnu.org; Mon, 30 Jul 2018 08:56:02 -0400 Subject: [bug#31999] [PATCH 2/7] gnu: Add ndctl. Resent-Message-ID: From: Marius Bakke In-Reply-To: <87bmap12di.fsf@gmail.com> References: <87o9fc6wnf.fsf@fastmail.com> <20180728220522.12078-1-ambrevar@gmail.com> <87va8x3clz.fsf@fastmail.com> <87bmap12di.fsf@gmail.com> Date: Mon, 30 Jul 2018 14:54:59 +0200 Message-ID: <878t5s3mu4.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Pierre Neidhardt Cc: 31999@debbugs.gnu.org --=-=-= Content-Type: text/plain Pierre Neidhardt writes: > Marius Bakke writes: > >>> + ("bash-completion" ,bash-completion) >> >> That's an unusual input. Can you add a comment about why it's needed? > > I took that from the Arch package > (https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/ndctl) > but it's obviously not required. > That said, should I add bash-completion as an input or leave it out? I > tend to see this as "optional", so I'd rather leave it out. Not sure > what the Guix policy is in this regard. It depends on what it's used for. If it's needed to install bash completions or something, let's keep it. If it does not make any difference... well that's one less dependency to worry about! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAltfCqMACgkQoqBt8qM6 VPqNNAf/cq/0ykezjmQxoh/ogtsMZeqhwvO+d63lGjat++qlV4asmu2CR3QT3IM7 LTBl939k/caqsl0siDa230/o8cRN2p2SDtDtlpG4jcAH7/P7f3jI41hs0cuX0w9L mRRAeNSdWhr5mwT8jCgDim6XZVC75O1j/ZD1ztgp+h8NIDQOdOiutrCEY9ST3e3E tKlC84iKmsHkCF8rWEAvqWivWsYAcc8EhFaVipNwtc0Reh6Cp4pj06WW50Mvh6Zg +W+qKoAkVfyzNi6RM8M1ZPJI6ME6iQ9P8GezbHhD0W5OYobIqn9uI+q690JPClvg szUQmM98aehJiYg+U7qMM2LLpcEAsA== =P7NI -----END PGP SIGNATURE----- --=-=-=--