From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33889) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fv9Dy-0008H2-9w for guix-patches@gnu.org; Wed, 29 Aug 2018 18:46:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fv9Dv-00049d-3o for guix-patches@gnu.org; Wed, 29 Aug 2018 18:46:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:60824) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fv9Du-00049S-TR for guix-patches@gnu.org; Wed, 29 Aug 2018 18:46:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fv9Du-0001FO-Ph for guix-patches@gnu.org; Wed, 29 Aug 2018 18:46:02 -0400 Subject: bug#32141: [PATCH] services: Add ddclient service. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Oleg Pykhalov References: <20180713145854.12250-1-go.wigust@gmail.com> <87lga7wokr.fsf@gnu.org> <87effrpynp.fsf@gmail.com> <87o9eu2xl1.fsf@gnu.org> <874lgengj9.fsf@gmail.com> <87zhx8awai.fsf@gnu.org> Date: Thu, 30 Aug 2018 01:45:27 +0300 In-Reply-To: <87zhx8awai.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 27 Aug 2018 13:22:45 +0200") Message-ID: <878t4oeqrc.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 32141-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludovic, ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Sorry for the delay, I had forgotten about this patch. (Feel free to > ping when that happens!) No problem. OK. Feel free the same and thank you for pinging me. > Oleg Pykhalov skribis: [=E2=80=A6] >> +By default, the @code{secret-file} in @code{ddclient-configuration} is >> +pointing to @file{/etc/ddclient/secrets.conf} file, which will be appen= ded to >> +@file{/etc/ddclient/ddclient.conf} and should be created in advance. S= ee >> +samples inside @file{/share/ddclient} directory of @code{ddclient} pack= age. > > I propose slightly different wording, to make it clear that users are > expected to provide the secret file: > > The following example show instantiates the service with its default > configuration: > > @example > (service ddclient-service-type) > @end example > > Note that ddclient needs to access credentials that are stored in a > @dfn{secret file}, by default @file{/etc/ddclient/secrets} (see > @code{secret-file} below.) You are expected to create this file > manually, in an ``out-of-band'' fashion (you @emph{could} make this > file part of the service configuration, for instance by using > @code{plain-file}, but it will be world-readable @i{via} > @file{/gnu/store}.) See the examples in the @file{share/ddclient} > directory of the @code{ddclient} package. > > WDYT? It looks more clear. I will apply this, thanks. >> +@deftypevr {@code{ddclient-configuration} parameter} string secret-file >> +Secret file which will be appended to ddclient.conf file. > ^ > @file{ddclient.conf} > > Maybe add: > > This file contains credentials for use by ddclient. You are expected > to create it manually. > >> +Defaults to @samp{"/etc/ddclient/secrets.conf"}. Applied. > OK with changes along these lines. Pushed as 8490a8346b5c8207f5798be55bea1de865b0bd42 Thanks, Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAluHIgcACgkQckbhHGm3 lWnr3g//ePLrI8+BUd2KZaBAYPnNMxXU0z75uPm6Hh6gQBX96ljxlATkGVCU9UfD U+IuIMsWP8XsVgrj0qmW+MfYK6F7NWI/ZrkzsaGftin+i+h1zKOahdHbds/Je3XS 9mWGX8ndYJU6y3+eC9KX7hicZ7jkLpM11IkPC1zSMsQhxBSzOyqSG4kiAz3ij3OW C2W1F6W1FaltrXcKKih4kl2DelTCGBh0KTUHJ4k3QKs4m6uCvRPV9xS2H25Je6Xd AjE1lzjSz3imWeJQ+8A6TVhVb/ofUk3WaL3h85JbBuxzuhWdjTw7S6l/BlgxzKw5 4I+DmnQG4CIZrjf+cpzFEaZIpk9evB2n0EWZDTYvuIiUuLKm1b7hxC1e2VI1+LSL Uv3pQrvtTr5HMD7zSCAj0HOElAfw+eTMNCddZv/NuNn1etmobSXSJly4VHnXNirs YJtUuO3TorhGAyPfimMT5b1Vf0bR23bWtxdcWAe4lRii8709Cfywmde55tKjPjio sMUhduGbkQCIneScN/ijTZ2Q00b4/36Pt4rRwKFaconP9XDeAousYnvOywfwFX4L VZ3P1SN25kWE0+PY7AqxYxrIQoHNBX0/ceJEvzSavvFn4UU26ti08lMfExvJLVTj Wj1YQtO8qVrdkzb1W654q0Ow4PrVy57PxUUT5iuPgZZoOK8CAu4= =PI5A -----END PGP SIGNATURE----- --=-=-=--