From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55277) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gbJkl-0004fb-DY for guix-patches@gnu.org; Mon, 24 Dec 2018 01:30:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gbJkc-0003jh-Ih for guix-patches@gnu.org; Mon, 24 Dec 2018 01:30:13 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:58188) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gbJkY-0003gL-Pt for guix-patches@gnu.org; Mon, 24 Dec 2018 01:30:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gbJkY-0001C9-JO for guix-patches@gnu.org; Mon, 24 Dec 2018 01:30:02 -0500 Subject: [bug#33849] [PATCH] gnu: Add polybar In-Reply-To: <87imzkfe3g.fsf@gmail.com> Resent-Message-ID: From: Meiyo Peng References: <87imzkfe3g.fsf@gmail.com> <87zhswgmyo.fsf@gnu.org> Date: Mon, 24 Dec 2018 14:27:33 +0800 Message-ID: <878t0f5tii.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 33849@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Ludovic Court=C3=A8s writes: >> + (source >> + (origin >> + (method url-fetch) >> + (uri (string-append "https://github.com/jaagr/polybar/releases/" >> + "download/" version "/polybar.tar")) >> + (sha256 >> + (base32 "1zpsvh1n77bx7s6mqqh3ba828k9xbp35c2mjmcl9nywfp6r5ldqi")) >> + (file-name (string-append name "-" version ".tar")))) > > Please use =E2=80=98git-fetch=E2=80=99 rather than downloading a generate= d tarball (it=E2=80=99s > a generated tarball, right?). No. This is a user uploaded release tarball. You can notice their difference. User uploaded tarball has "/releases/download/" in its URL. #+BEGIN_EXAMPLE User uploaded: https://github.com/jaagr/polybar/releases/download/3.3.0/= polybar.tar Auto generated: https://github.com/jaagr/polybar/archive/3.3.0.tar.gz #+END_EXAMPLE I tried to use the git-fetch method first, but it failed to build because git-fetch doesn't fetch git submodules. Do we support recursively fetching git submodules? >> + (build-system cmake-build-system) >> + (arguments >> + ;; Test is disabled because it requires downloading googletest fro= m the >> + ;; Internet. >> + '(#:tests? #f)) > > Did you try adding =E2=80=98googletest=E2=80=99 to =E2=80=98native-inputs= =E2=80=99, and perhaps also > disabling the code that tries to download it? I checked the CMakeLists.txt, but it's too complex for me. I am not familiar with cmake, so I prefer not to patch it. > The rest LGTM! Could you send an updated patch? The author released a new version after I sent the last patch. So here is a new patch with version 3.3.0. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-Add-polybar.patch >From 3faa9dcf77ca83972db6234a9af6b22325ee0311 Mon Sep 17 00:00:00 2001 From: Meiyo Peng Date: Sun, 23 Dec 2018 23:05:38 +0800 Subject: [PATCH] gnu: Add polybar. * gnu/packages/wm.scm (polybar): New variable. --- gnu/packages/wm.scm | 43 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm index 2e211e389..a761bce23 100644 --- a/gnu/packages/wm.scm +++ b/gnu/packages/wm.scm @@ -76,6 +76,7 @@ #:use-module (gnu packages lua) #:use-module (gnu packages linux) #:use-module (gnu packages suckless) + #:use-module (gnu packages mpd) #:use-module (guix download) #:use-module (guix git-download)) @@ -1051,3 +1052,45 @@ its size @item Display preview images in a tiled icon layout @end itemize") (license license:gpl2+))) + +(define-public polybar + (package + (name "polybar") + (version "3.3.0") + (source + (origin + (method url-fetch) + (uri (string-append "https://github.com/jaagr/polybar/releases/" + "download/" version "/polybar.tar")) + (sha256 + (base32 "0sjh3xmf11g09spi88zj7xsc3a3vv78kixab6n5i7436py7xwzb4")) + (file-name (string-append name "-" version ".tar")))) + (build-system cmake-build-system) + (arguments + ;; Test is disabled because it requires downloading googletest from the + ;; Internet. + '(#:tests? #f)) + (inputs + `(("alsa-lib" ,alsa-lib) + ("cairo" ,cairo) + ("i3-wm" ,i3-wm) + ("libmpdclient" ,libmpdclient) + ("libnl" ,libnl) + ("libxcb" ,libxcb) + ("pulseaudio" ,pulseaudio) + ("xcb-proto" ,xcb-proto) + ("xcb-util" ,xcb-util) + ("xcb-util-cursor" ,xcb-util-cursor) + ("xcb-util-image" ,xcb-util-image) + ("xcb-util-wm" ,xcb-util-wm) + ("xcb-util-xrm" ,xcb-util-xrm))) + (native-inputs + `(("pkg-config" ,pkg-config) + ("python-2" ,python-2) ; lib/xpp depends on python 2 + ("python" ,python))) ; xcb-proto depends on python 3 + (home-page "https://polybar.github.io/") + (synopsis "Fast and easy-to-use status bar") + (description "Polybar aims to help users build beautiful and highly +customizable status bars for their desktop environment. It has built-in +functionality to display information about the most commonly used services.") + (license license:expat))) -- 2.20.0 --=-=-= Content-Type: text/plain -- Meiyo Peng https://www.pengmeiyu.com/ --=-=-=--