Hi,

Ludovic Courtès <ludo@gnu.org> writes:

>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append "https://github.com/jaagr/polybar/releases/"
>> +                           "download/" version "/polybar.tar"))
>> +       (sha256
>> +        (base32 "1zpsvh1n77bx7s6mqqh3ba828k9xbp35c2mjmcl9nywfp6r5ldqi"))
>> +       (file-name (string-append name "-" version ".tar"))))
>
> Please use ‘git-fetch’ rather than downloading a generated tarball (it’s
> a generated tarball, right?).

No. This is a user uploaded release tarball. You can notice their
difference. User uploaded tarball has "/releases/download/" in its URL.

#+BEGIN_EXAMPLE
  User uploaded:  https://github.com/jaagr/polybar/releases/download/3.3.0/polybar.tar
  Auto generated: https://github.com/jaagr/polybar/archive/3.3.0.tar.gz
#+END_EXAMPLE

I tried to use the git-fetch method first, but it failed to build
because git-fetch doesn't fetch git submodules. Do we support
recursively fetching git submodules?

>> +    (build-system cmake-build-system)
>> +    (arguments
>> +     ;; Test is disabled because it requires downloading googletest from the
>> +     ;; Internet.
>> +     '(#:tests? #f))
>
> Did you try adding ‘googletest’ to ‘native-inputs’, and perhaps also
> disabling the code that tries to download it?

I checked the CMakeLists.txt, but it's too complex for me.  I am not
familiar with cmake, so I prefer not to patch it.

> The rest LGTM!  Could you send an updated patch?

The author released a new version after I sent the last patch. So here
is a new patch with version 3.3.0.