From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: hard-coded /gnu/store patches cause test-env to not work properly Date: Tue, 08 Jan 2019 09:08:46 +0100 Message-ID: <878szv8tbl.fsf@elephly.net> References: <87tvijfv9m.fsf@cune.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([209.51.188.92]:54913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggmgk-0007gF-Iy for guix-devel@gnu.org; Tue, 08 Jan 2019 03:24:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggmgg-0004x7-NZ for guix-devel@gnu.org; Tue, 08 Jan 2019 03:24:42 -0500 Received: from sender-of-o53.zoho.com ([135.84.80.218]:21818) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ggmgg-0004Y1-1s for guix-devel@gnu.org; Tue, 08 Jan 2019 03:24:38 -0500 In-reply-to: <87tvijfv9m.fsf@cune.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Caleb Ristvedt Cc: guix-devel@gnu.org Hi Caleb, > Well, I finally (it only took 4 days!) found out what was causing > python2-flake8@3.5.0 to fail to build only in the test environment: > python-2.7-site-prefixes.patch Ouch! > If we aren't assuming NIX_STORE is set for non-/gnu/store installs, then > I guess we'd have to start generating patches based on the configured > storedir. I think this would be better. The patch could contain the @GUIX_STORE@ placeholder, which you then patch out in a snippet. -- Ricardo