From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:40164)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hOnYV-0003ky-4G
	for guix-patches@gnu.org; Thu, 09 May 2019 14:14:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hOnYU-00014s-6C
	for guix-patches@gnu.org; Thu, 09 May 2019 14:14:07 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:51067)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hOnYT-00012b-BP
	for guix-patches@gnu.org; Thu, 09 May 2019 14:14:06 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hOnYT-0003Xu-0W
	for guix-patches@gnu.org; Thu, 09 May 2019 14:14:05 -0400
Subject: bug#35652: [PATCH] services: dhcp-client: Ignore non-ARP network
	interfaces.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.35652.D35652.155742558513550.done@debbugs.gnu.org>
From: Marius Bakke <mbakke@fastmail.com>
In-Reply-To: <87mujvd4cy.fsf@gnu.org>
References: <87d0krd4s6.fsf@fastmail.com> <87mujvd4cy.fsf@gnu.org>
Date: Thu, 09 May 2019 20:12:54 +0200
Message-ID: <878svfcx95.fsf@fastmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 35652-done@debbugs.gnu.org

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Ludovic Court=C3=A8s <ludo@gnu.org> writes:

> Hi Marius,
>
> Good catch!
>
> Marius Bakke <mbakke@fastmail.com> skribis:
>
>> From 7724f24443392fdfc2c075909d9b64350f6578b2 Mon Sep 17 00:00:00 2001
>> From: Marius Bakke <mbakke@fastmail.com>
>> Date: Thu, 9 May 2019 17:03:03 +0200
>> Subject: [PATCH] services: dhcp-client: Ignore interfaces that are not A=
RP
>>  capable.
>>
>> * guix/build/syscalls.scm (IFF_NOARP): New variable.
>> (arp-network-interface?): New public variable.
>> * gnu/services/networking.scm (dhcp-client-service-type): Filter interfa=
ces
>> that do not support the ARP protocol.
>
> Could you make it two patches (one for syscalls.scm, and another one for
> the rest)?
>
> Otherwise LGTM, thank you!

Thanks for the amazingly fast review :-)

Pushed in a0dc97a5..6c2180f5.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlzUbaYACgkQoqBt8qM6
VPqTVgf/VP62RoL6ivoNJEDAubSHlh3wqRGBtQjLigRseUrmoZ119+PV11SelR+T
UdjHZJYPPg3Fh8IGQBky3GtO83Wo2y7EEyk3Ci+dlUD8op073+zuLTj7DM9y1ajU
zLAN51uNGjyLFh0DO9W4BgbG8qig5KOYnOx5fEbH6tfeAhgch63UMfpCQQhYL1KW
LU0b7ovURxQBXipI4qH5wLb9l47ycSeeYetoZsQrEEf4ztlfjnq3KB6VMYNvaW98
te34g3nPvb+F6sIetoa99u7NcTWgCOvChYgwZLMRLGp6paCre6+RgyyASQLuALR1
+bcxpdUviJ9Qh5rWrwKe+jX4l8d+Nw==
=GmvQ
-----END PGP SIGNATURE-----
--=-=-=--