all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 35652-done@debbugs.gnu.org
Subject: bug#35652: [PATCH] services: dhcp-client: Ignore non-ARP network interfaces.
Date: Thu, 09 May 2019 20:12:54 +0200	[thread overview]
Message-ID: <878svfcx95.fsf@fastmail.com> (raw)
In-Reply-To: <87mujvd4cy.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 819 bytes --]

Ludovic Courtès <ludo@gnu.org> writes:

> Hi Marius,
>
> Good catch!
>
> Marius Bakke <mbakke@fastmail.com> skribis:
>
>> From 7724f24443392fdfc2c075909d9b64350f6578b2 Mon Sep 17 00:00:00 2001
>> From: Marius Bakke <mbakke@fastmail.com>
>> Date: Thu, 9 May 2019 17:03:03 +0200
>> Subject: [PATCH] services: dhcp-client: Ignore interfaces that are not ARP
>>  capable.
>>
>> * guix/build/syscalls.scm (IFF_NOARP): New variable.
>> (arp-network-interface?): New public variable.
>> * gnu/services/networking.scm (dhcp-client-service-type): Filter interfaces
>> that do not support the ARP protocol.
>
> Could you make it two patches (one for syscalls.scm, and another one for
> the rest)?
>
> Otherwise LGTM, thank you!

Thanks for the amazingly fast review :-)

Pushed in a0dc97a5..6c2180f5.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

      reply	other threads:[~2019-05-09 18:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-09 15:30 [bug#35652] [PATCH] services: dhcp-client: Ignore non-ARP network interfaces Marius Bakke
2019-05-09 15:39 ` Ludovic Courtès
2019-05-09 18:12   ` Marius Bakke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878svfcx95.fsf@fastmail.com \
    --to=mbakke@fastmail.com \
    --cc=35652-done@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.