From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:36462)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iy0xn-0004M3-SA
 for guix-patches@gnu.org; Sat, 01 Feb 2020 17:10:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iy0xm-00013K-O0
 for guix-patches@gnu.org; Sat, 01 Feb 2020 17:10:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:33432)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iy0xm-00012S-Jn
 for guix-patches@gnu.org; Sat, 01 Feb 2020 17:10:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iy0xm-0001xf-Dm
 for guix-patches@gnu.org; Sat, 01 Feb 2020 17:10:02 -0500
Subject: [bug#39384] [PATCH] gnu: Add emacs-rg.
Resent-Message-ID: <handler.39384.B39384.15805949727488@debbugs.gnu.org>
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
References: <87v9oqrr0q.fsf@lafreniere.xyz>
Date: Sat, 01 Feb 2020 23:09:19 +0100
In-Reply-To: <87v9oqrr0q.fsf@lafreniere.xyz> (Joseph LaFreniere's message of
 "Sat, 01 Feb 2020 14:28:37 -0600")
Message-ID: <878slmc640.fsf@nicolasgoaziou.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: "LaFreniere, Joseph" <joseph@lafreniere.xyz>
Cc: 39384@debbugs.gnu.org

Hello,

"LaFreniere, Joseph" <joseph@lafreniere.xyz> writes:

> Patch file is attached to package https://github.com/dajva/rg.el.git.

Thank you! Some comments follow.

> +       (sha256
> +        (base32
> +         "0k7x5z7mh9flwih35cqy8chs54rack3nswdcpw5wcpgv6xim227y"))))

Nitpick: I think the trend is to align `base32' with the string.

> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +     `(("emacs-s" ,emacs-s)
> +       ("emacs-wgrep" ,emacs-wgrep)
> +       ("ripgrep" ,ripgrep)))
> +    (home-page "https://rgel.readthedocs.io/en/latest/")
> +    (synopsis "A search tool based on @code{ripgrep}")

You may want to lint your package. In particular, the synopsis should be
akin to "Search tool based ..."

> +    (description
> +     "An Emacs search package based on the @code{ripgrep} command line

The description must start with a full sentence, e.g., "rg.el" is an
Emacs search package...

> +tool. It allows you to interactively create searches, doing automatic se=
arches

Texinfo requires two spaces after the full stop.

> +based on the editing context, refining and modifying search results and =
much
> +more. It is also highly configurable to be able to fit different users=
=E2=80=99

Ditto. Besides, the quote after "users" looks suspicious. You should use
a regular quote.

Could you send an updated patch?

Regards,

--=20
Nicolas Goaziou